Persist stripe subscription ID on Subscription - #192
Open
trestrantham wants to merge 2 commits into
Open
trestrantham wants to merge 2 commits into
trestrantham wants to merge 2 commits into
Conversation
| end | ||
|
|
||
| if subscription_owner.respond_to? :stripe_id | ||
| subscription_owner.update(stripe_id: customer.id) |
Owner
There was a problem hiding this comment.
@trestrantham Hey. Curious why you'd want to write the Stripe ID to the subscription owner instead of just referencing from the Subscription (where it would already be)?
Author
There was a problem hiding this comment.
This was just a half measure to moving Stripe::Customer#id from Subscription to Team while maintaining backward compatibility. Ideally IMO, Subscription#stripe_id would be a Stripe::Subscription#id and Team#stripe_id would be a Stripe::Customer#id. I keep getting hung up on the current mismatch. That being said, happy to remove it to avoid confusion. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also clones stripe customer ID to subscription owner (Team), too. This keeps backwards compatibility by naming the attribute
Subscription#stripe_subscription_idrather than repurposingSubscription#stripe_id(which is really the stripe customer ID).I didn't see any tests for this concern so please advise if there's a preferred test approach.