Replace PyCrypto with PyCryptoDome

[KyleKing]

This PR replaces the pyCrypto dependency with the actively maintained (and backward compatible) pyCryptoDome. See discussion on EOL for PyCrypto

• Fixes ImportError: No module named 'winrandom' #17
• FIxes Dependancy pyCrypto no longer installs on modern windows #20
• Fixes pycrypto depdency security vulnerability #21
• Fixes Python3.8 AttributeError: module 'time' has no attribute 'clock' #27
• Fixes Unable to install simple-crypt #28
• Alternative to PR Change pycrypto dependency to pycryptodome, delete unneccesary files #22 and Update pycrypto requirement to pycryptodome, for better supporting on Windows #24
  • The fork for PR Change pycrypto dependency to pycryptodome, delete unneccesary files #22 appears to be deleted and can't be merged
  • I didn't see Update pycrypto requirement to pycryptodome, for better supporting on Windows #24 before creating this PR, but this PR goes a little farther and updates documentation, etc.
• And improves performance in KyleKing@76dc7b8

All tests pass; however, I had to skip a test that called a feature of pyCrypto (ctr()) that was changed in pyCryptoDome. If this PR will be merged, I can spend some time to figure out how to re-implement that test

❯ nosetests -x
.....................
----------------------------------------------------------------------
Ran 21 tests in 437.129s

OK

---

Update: I'll keep my fork live and will accept PRs. You can install the package from my fork with:

pip install git+https://github.com/KyleKing/simple-crypt.git

I've been using the fork for almost a year in Python 3.9 and 3.6 with backward compatibility with the official simple-crypt 4.1.7 in a Python 2.7 project without issue. Hopefully, these changes can be merged and released so others can benefit!

[zmarffy]

Doesn't seem to work on 3.9. ModuleNotFoundError: No module named 'Crypto'.

[KyleKing]

Can you check that crypto and pycrypto are uninstalled? If not, can you send me the full stack trace? I tested locally in a new venv with Python 3.9.0 on Mac and was able to run the below script

# check_imports.py
from simplecrypt import encrypt, decrypt

password = 'pass'
ciphertext = encrypt(password, 'my secret message')
plaintext = decrypt(password, ciphertext)
print(ciphertext, plaintext)

[zmarffy]

@KyleKing I'm dumb. Had the extra stuff installed. Thanks. Good stuff.

[KyleKing]

@andrewcooke can you please take a look and consider merging this change?

I need to use simple-crypt in a project with Python ^3.8 that is backward compatible with files encrypted with simple-crypt 4.1.7

[KyleKing]

This PR is still ready for review/merge/release if there is any interest!

[KyleKing]

Still ready for review!

[helpdeskdan]

Fork!

[KyleKing]

@andrewcooke would you be interested in merging this PR? I figured it would be worth trying to reach out again to merge my fork back into the upstream

I had recently merged my fork of textract with upstream (https://github.com/KyleKing/textract-py3) and am now regular contributing to the project maintenance and would be happy to help in the same way here