-
-
Notifications
You must be signed in to change notification settings - Fork 319
feat(platform): add selectorless compilation support #2292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
benpsnyder
wants to merge
22
commits into
analogjs:alpha
Choose a base branch
from
benpsnyder:feat/selectorless-investigation-preserved
base: alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3de0537
test(vite-plugin-nitro): add snapshot test for Vite config mutations
benpsnyder 8826989
feat(vite-plugin-angular): enhance debugging documentation and improv…
benpsnyder 6f72fa1
feat: add error handling for @reference in comments and improve direc…
benpsnyder 43a5438
chore: update dependencies and configurations for Docusaurus and Angu…
benpsnyder 70263db
chore: update debugging documentation with additional package overrid…
benpsnyder efcb7f2
chore: update debugging documentation to clarify usage of catalog and…
benpsnyder e76e35a
docs: enhance documentation on duplicate analog() registrations and S…
benpsnyder 9f39aa7
Merge remote-tracking branch 'origin/alpha' into feat/support-snyder-…
benpsnyder 18312c0
Merge remote-tracking branch 'origin/alpha' into feat/support-snyder-…
benpsnyder 229b9e4
chore: update comments for clarity in Angular and Nitro plugins, and …
benpsnyder 3155d19
feat: enhance configuration handling and improve test stability by cl…
benpsnyder e0b491b
chore: refine comments and enhance test stability in Angular and Nitr…
benpsnyder 71b31a9
feat: improve handling of CSS comments and references, ensuring quote…
benpsnyder 69af095
feat: add function to detect @reference text in comments and refine C…
benpsnyder ac4a4ca
feat: refactor CSS directive handling by extracting utility functions…
benpsnyder ac2dd07
feat: implement TailwindReferenceError handling in JIT plugin and aug…
benpsnyder 00a43bd
fix: update console warning implementation in JIT plugin tests to ret…
benpsnyder 49e660b
feat: add support for selectorless compilation in Angular plugin, enh…
benpsnyder 6679136
Merge remote-tracking branch 'analogjs/alpha' into feat/snyder-suppor…
benpsnyder cb5feab
feat(vite-plugin-angular): enhance live reload plugin with Windows pa…
benpsnyder 638d30e
feat(vite-plugin-angular): improve selectorless compilation handling …
benpsnyder 756a1de
Merge remote-tracking branch 'analogjs/alpha' into feat/selectorless-…
benpsnyder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Route auto-detection now outruns the selectorless safety gate.
This new heuristic enables selectorless mode for
src/app/routes/app/routes, but the later validation path still only exempts/pages/and.page.*inisLikelyPageOnlyComponent(). A selectorless route entry component will therefore get_enableSelectorlessand then still fail with the explicit-selector error. Reuse the same route-file predicate in both places so route entries stay supported.Possible fix
function isLikelyPageOnlyComponent(id: string): boolean { return ( + isSelectorlessRouteFile(id) || id.includes('/pages/') || /\.page\.[cm]?[jt]sx?$/i.test(id) || /\([^/]+\)\.page\.[cm]?[jt]sx?$/i.test(id) ); }🤖 Prompt for AI Agents