projects/ad469x_evb: Add PWM_OFFLOAD parameter for ad4692 support #2030
Merged
projects/ad469x_evb: Add PWM_OFFLOAD parameter for ad4692 support #2030
Conversation
PIoandan
requested review from
IuliaCMoldovan,
LBFFilho,
StancaPop,
gastmaier,
ladace and
sarpadi
as code owners
sarpadi
requested changes
Mar 30, 2026
| ``` | ||
| cd projects/ad469x_evb/coraz7s | ||
| make SPI_4WIRE=0 | ||
| make SPI_4WIRE=0 PWM_OFFLOAD=0 |
Contributor
There was a problem hiding this comment.
Readme must contain all valid parameter combination
| ``` | ||
| cd projects/ad469x_evb/zed | ||
| make SPI_4WIRE=0 | ||
| make SPI_4WIRE=0 PWM_OFFLOAD=0 |
Contributor
There was a problem hiding this comment.
Readme must contain all valid parameter combination
| adi_project ad469x_evb_coraz7s 0 [list \ | ||
| SPI_4WIRE [get_env_param SPI_4WIRE 0]] | ||
| SPI_4WIRE [get_env_param SPI_4WIRE 0] \ | ||
| PWM_OFFLOAD [get_env_param PWM_OFFLOAD 0]] |
| set PWM_OFFLOAD $ad_project_params(PWM_OFFLOAD) | ||
| } else { | ||
| set PWM_OFFLOAD 0 | ||
| } |
Contributor
There was a problem hiding this comment.
why use different param handling?
|
|
||
| # CNV gating configuration | ||
|
|
||
| if {$PWM_OFFLOAD == 0} { |
Contributor
There was a problem hiding this comment.
duplicating IF statements looks confusing. use single IF statements and comment properly. what is the relation with the SPI_4WIRE param?
Collaborator
Author
There was a problem hiding this comment.
Slightly reorganized.
sarpadi
approved these changes
Apr 29, 2026
Signed-off-by: sarpadi <[email protected]> Signed-off-by: Pop Ioan Daniel <[email protected]>
Signed-off-by: Pop Ioan Daniel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Add PWM_OFFLOAD parameter to support ad4692 register and manual modes alongside the existing ad469x functionality.
PR Type
PR Checklist