library/spi_engine: fix deadlock #2021
Closed
LBFFilho wants to merge 1 commit into
Closed
Conversation
Fix a possible deadlock that could happen if the offload program ended with a chip-select or sleep instruction after a transfer instruction. If the data stream stopped after the last transfer instruction, any following instruction that uses the sleep counter (including chip-select instructions with non-zero delay) would lock up and never finish execution. Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
LBFFilho
requested review from
IuliaCMoldovan,
StancaPop,
gastmaier,
ladace,
podgori and
sarpadi
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a possible deadlock that could happen if the offload program has a chip-select or sleep instruction after a transfer instruction.
If the data stream stopped after the last transfer instruction (the DMA stopping receiving SDI data, for instance), any following instruction that uses the sleep counter (including chip-select instructions with non-zero delay) would lock up and never finish execution.
This was causing timeouts on cn0540/de10nano when disabling offload.
PR Type
PR Checklist