projects/xcvr_wizard/scripts: Fix HDL for XCVR automation in TB#1999
Open
hadarauelena wants to merge 7 commits intomainfrom
Open
projects/xcvr_wizard/scripts: Fix HDL for XCVR automation in TB#1999hadarauelena wants to merge 7 commits intomainfrom
hadarauelena wants to merge 7 commits intomainfrom
Conversation
hadarauelena
requested review from
AndrDragomir,
AndreiGrozav,
FilipG24,
IuliaCMoldovan,
PopPaul2021,
acostina,
gastmaier and
sarpadi
as code owners
Contributor
|
RetriggerCI |
Contributor
IstvanZsSzekely
left a comment
IstvanZsSzekely
left a comment
There was a problem hiding this comment.
Would it make sense to source the adi_xcvr_xilinx.tcl script inside the adi_project_xilinx.tcl?
If it's imported by default in every Xilinx project, then the system_project.tcl files would remain untouched.
IstvanZsSzekely
requested changes
Mar 25, 2026
Contributor
IstvanZsSzekely
left a comment
IstvanZsSzekely
left a comment
There was a problem hiding this comment.
Please rebase the branch on current main. There are some testbenches that fail since they are out of sync.
Collaborator
Author
Done |
Signed-off-by: Elena-Hadarau_adi <Elena.Hadarau@analog.com>
Signed-off-by: Elena-Hadarau_adi <Elena.Hadarau@analog.com>
Signed-off-by: Elena-Hadarau_adi <Elena.Hadarau@analog.com>
The previous approach modified util_adxcvr_xc[m|h].v in-place and then reverted it with git checkout. Even though the content was restored, the file timestamp was updated, causing build systems to unnecessarily rebuild util_adxcvr. Create a temporary .new copy of the file, stage it to record the original content, write the modified attributes to the copy, and generate the diff from the staged vs. working tree version. The original file is never touched, preserving its timestamp. Signed-off-by: Elena-Hadarau_adi <Elena.Hadarau@analog.com>
Signed-off-by: Elena-Hadarau_adi <Elena.Hadarau@analog.com>
Signed-off-by: Elena-Hadarau_adi <Elena.Hadarau@analog.com>
Signed-off-by: Elena-Hadarau_adi <Elena.Hadarau@analog.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Added the new script adi_xcvr_xilinx.tcl under the new scripts folder in the xcvr_wizard project. Updated the adi_xcvr_project function to allow sourcing the script directly from the testbench repository.
Updated adi_xcvr_project function to accept the board name as a new optional parameter. If the parameter is provided, the script will use that value; if not, it will be automatically extracted from the directory name.
PR Type
PR Checklist