library/axi_ad9361/xilinx: Fix frame delineation error check#1968
Open
eemincetin wants to merge 1 commit intoanalogdevicesinc:hdl_2023_r2from
Open
library/axi_ad9361/xilinx: Fix frame delineation error check#1968eemincetin wants to merge 1 commit intoanalogdevicesinc:hdl_2023_r2from
eemincetin wants to merge 1 commit intoanalogdevicesinc:hdl_2023_r2from
Conversation
The rx_error_r1 and rx_error_r2 checks were only using rx_frame_s (2 bits)
instead of the concatenated {rx_frame_s, rx_frame} (4 bits) to properly
validate frame alignment across consecutive clock cycles.
Signed-off-by: Emin Cetin [email protected]
Signed-off-by: eminc <[email protected]>
eemincetin
requested review from
AndreiGrozav,
gastmaier and
podgori
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rx_error_r1 and rx_error_r2 checks were only using rx_frame_s (2 bits) instead of the concatenated {rx_frame_s, rx_frame} (4 bits) to properly validate frame alignment across consecutive clock cycles.
Signed-off-by: Emin Cetin [email protected]
Warning - these changes have not been tested on the corresponding hardware / setup / boards!
PR Description
The rx_error_r1 and rx_error_r2 checks were only using rx_frame_s (2 bits)
instead of the concatenated {rx_frame_s, rx_frame} (4 bits) to properly
validate frame alignment across consecutive clock cycles.
PR Type
PR Checklist