Repository navigation
Mark the body of a response as a Psalm taint source - #403
Merged
Merged
Conversation
kelunik
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks
Response::getBody()as a Psalm taint source (@psalm-taint-source input): what another server sends back is untrusted. With amphp/byte-stream#118 (Payload's methods return what the payload holds), what the code reads from the body is tainted too, so Psalm follows it into the sinks it reaches.Docblock only, no change at runtime. Psalm ships the same source in its stub for this library (vimeo/psalm#12482), which also declares the response's headers (
getHeaders(),getHeaderArray(),getHeader()) as sources; those methods are inherited from amphp/http'sHttpMessage, which also holds the requests the code builds, so they can't be annotated here without overriding them. The sinks ofRequestandFormare in #402.