Deploy user secrets via secrets.json file in TodoList.Web - #73
Open
JoeyBobbles wants to merge 1 commit into
Open
Deploy user secrets via secrets.json file in TodoList.Web#73JoeyBobbles wants to merge 1 commit into
JoeyBobbles wants to merge 1 commit into
Conversation
…t and instructions how to use the secrets.json file. Added new secrets.json with the appropriate nodes for import.
Codecov Report
@@ Coverage Diff @@
## develop #73 +/- ##
========================================
Coverage 31.14% 31.14%
========================================
Files 89 89
Lines 2427 2427
Branches 314 314
========================================
Hits 756 756
Misses 1653 1653
Partials 18 18 Continue to review full report at Codecov.
|
amoraitis
requested changes
May 4, 2020
amoraitis
left a comment
amoraitis
left a comment
Owner
There was a problem hiding this comment.
Please add a class that describes the secrets.json values and initialize it in the app's configuration in Startup.cs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #73 +/- ##
========================================
Coverage 31.14% 31.14%
========================================
Files 89 89
Lines 2427 2427
Branches 314 314
========================================
Hits 756 756
Misses 1653 1653
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated readme with formatting for bullet points and nested order list and instructions how to use the secrets.json file.
Added new secrets.json with the appropriate nodes for import which get flattened by the added README.md command
Closes #68