Open
Conversation
- Align CMake documentation - Suppress verbose output from compileall - Add a CMake-like installation message - Fix support for DESTDIR-based installations Signed-off-by: Scott K Logan <logans@cottsay.net>
ahcorde
approved these changes
Nov 11, 2025
sloretz
requested changes
Nov 11, 2025
|
|
||
| if(NOT ARG_SKIP_COMPILE) | ||
| get_executable_path(python_interpreter_config Python3::Interpreter CONFIGURE) | ||
| set(_bytecompile_target "\$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/${ARG_DESTINATION}/${package_name}") |
Contributor
There was a problem hiding this comment.
Same comment about generating the code at build time and then using install()
Co-authored-by: Shane Loretz <shane.loretz@gmail.com> Signed-off-by: Scott K Logan <logans@cottsay.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change should enable Python byte-compilation for RPM packages produced by the buildfarm, where the current code fails to target the correct installation directory.