Introduce relocatable <package>_IMPORT_PREFIX variable#389
Open
roehling wants to merge 2 commits intoament:rollingfrom
Open
Introduce relocatable <package>_IMPORT_PREFIX variable#389roehling wants to merge 2 commits intoament:rollingfrom
roehling wants to merge 2 commits intoament:rollingfrom
Conversation
This moves the logic to compute the install prefix to a single location in the main config file. Extra config files can use the new AMENT_IMPORT_PREFIX variable, which simplifies the code and makes it more robust to future changes. The logic to compute AMENT_IMPORT_PREFIX has been taken from the CMakePackageConfigHelpers module. The code is well-tested and also handles symlink aliasing. Signed-off-by: Timo Röhling <roehling@debian.org>
Signed-off-by: Timo Röhling <roehling@debian.org>
roehling
force-pushed
the
ament_import_prefix
branch
from
8aad271 to
d148e76
Compare
roehling
changed the title
Contributor
Author
|
Any progress on the review for this PR? I still think the import prefix would be quite useful and much more readable than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the logic to compute the install prefix to a single location
in the main config file. Extra config files can use the new
<package>_IMPORT_PREFIXvariable, which simplifies the code and makes itmore robust to future changes.
The logic to compute
<package>_IMPORT_PREFIXhas been taken from theCMakePackageConfigHelpers module. The code is well-tested and also
handles symlink aliasing.
EDIT I renamed
AMENT_IMPORT_PREFIXto<package>_IMPORT_PREFIXbecause initially, I did not take recursivefind_package()calls into account, which may clobber a single global variable.