feat: register queries and typed variables for hosted data apps by robinvrd · Pull Request #33 · altertable-ai/data-app

robinvrd · 2026-10-02T13:50:00Z

Summary

Hosted data apps execute registered queries by ID and variable values through the existing bridge. SQL templates stay on the host.

Add TypeScript types for query registration and variable definitions with name, type, nullable, default, and optional options, matching the frontend's supported types.
Add variable selectors with compact, shared single-date and date-range calendar pickers. Range controls retain presets, bounds, reset, and comparison; single dates use the same calendar navigation without range presets.
Add the data:query payload { operation, variables, limit } using the existing bridge.
Update the hosted starter and docs to produce three artifacts: app source, queries.json, and variables.json.

Variable and SQL parsing, registration validation, defaults, and query execution belong to the backend. This package supplies TypeScript types, selectors, and transport; the hosted preview uses mock backend results.

Local CLI apps keep their existing HTTP operations and server-owned SQL flow.

Hosted flow

On creation and every source update, submit source, the complete query map, and the complete variable list together.
App code calls query(queryId, values); the bridge forwards the ID and values to the frontend.
The frontend calls runDataAppQuery with the trusted app slug, query ID, and values. The backend resolves the saved SQL, validates and binds values, authorizes access, and executes.
Results return through the bridge for parsing and display. Hosted apps have no raw SQL fallback.

The frontend and create/update integration are coordinated with frontend #2766 and skills #87.

Validation

bun run check with Bun 1.4.2 passed, including 188 tests and local starter verification.
Full browser suite: 129 passed, 11 skipped across desktop and phone, including shared calendar navigation, presets, bounds, reset, and comparison.
Markdown, links, and formatting checks passed after the documentation cleanup.

albert20260301

The required browser suite is failing in browser-tests/bridge-source.spec.ts on both desktop and phone. After clicking Data query, the iframe still shows the prior virtual-state result ({"period":"last-7","version":1}), not the query result the test expects.

Please update the bridge fixture and coverage so this path either exercises the new registered data:query contract (including the operation ID and values) or explicitly preserves and verifies the legacy data:sql path. The current failure leaves the feature's route-selection and backward-compatibility behavior unverified.

francoischalifour · 2026-10-06T14:50:05Z

    return null;
  }
-  const router = createMessageRouter(
+  const legacyRouter = createMessageRouter(


We can remove all things legacy

francoischalifour · 2026-10-06T14:59:38Z

  missingOption?: ComboboxOption;
  disabled?: boolean;
  placeholder?: string;
+  searchable?: boolean;


This isn't semantically correct. A combobox is always searchable. We should use another component when we don't need search.

francoischalifour · 2026-10-06T15:52:19Z

+    valid() {
+      return true; // Query values are validated by the backend.
+    },


Do we need this then?

francoischalifour · 2026-10-06T15:53:09Z

+          from: range.start ? new Date(`${range.start}T00:00:00.000Z`) : null,
+          to: range.end ? new Date(`${range.end}T23:59:59.999Z`) : null,


Perhaps could extract date utils for agents to reuse across the app: startOfDay(), endOfDay().

francoischalifour · 2026-10-06T15:56:13Z

+
+/** Display URL or controlled values without making malformed values crash the UI. */
+export function formatVariableDate(
+  value: AbsoluteOrRelativeDateTime | null | undefined


Do we still need to carry these GraphQL dependent typings here? Ideally we narrow down possible types.

francoischalifour · 2026-10-06T15:57:23Z

+  onChange,
+  nullable = false,
+  options,
+}: ValueProps<string | number> & { type: 'STRING' | 'INTEGER' | 'FLOAT' }) {


We should have a single type dictionary and pick from there so that types flow down.

francoischalifour · 2026-10-06T15:58:01Z

+        type === 'STRING'
+          ? 'Enter a value'
+          : `Enter a valid ${type === 'INTEGER' ? 'integer' : 'number'}`


Could use a map instead of fragile conditionals that might break with additional data types. We can type check them.

francoischalifour · 2026-10-06T16:00:28Z

+  function option(value: boolean | null) {
+    return choice(value, value === null ? 'Null' : value ? 'True' : 'False');
+  }


Good to extract too

francoischalifour · 2026-10-06T16:01:23Z

+        option(value)
+      )}
+      onChange={next =>
+        onChange(JSON.parse(next) as VariableValue<'INTERVAL'> | null)


We could provide a safe parsing function that casts?

albert20260301 · 2026-10-07T09:21:59Z

@robinvrd the current head now conflicts with main, and only the semantic-title check has rerun after the latest styling change.

Please rebase and resolve the conflict before the next review. The required source/package and browser checks need to rerun on that resolved head, and François's active design-review threads still need to be addressed or resolved.

leonkenneth · 2026-10-07T16:19:24Z

So following https://github.com/altertable-ai/backend/pull/4571 I think we can remove the variables part.

Then we will need to update the frontend and finally the skills I believe

leonkenneth · 2026-10-07T16:22:48Z

We can also update the bun proxy logic

leonkenneth · 2026-10-07T16:22:56Z

We can also update the bun proxy logic

albert20260301 · 2026-10-07T16:23:45Z

@leonkenneth @francoischalifour #33 is still conflicting and has active review feedback. Can you confirm whether the intended scope is now to remove hosted variables rather than finish this registration layer? Once confirmed, Robin should either re-scope/rebase this PR or replace it; I will not advance the existing implementation against an unsettled contract.

Registered queries now use DuckDB prepared-statement parameters ($name), so apps only register queries and pass a name-to-value hash. Removes the variable definitions, queryVariable(), and the variable selectors; the date pickers keep their own browser coverage. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Resolve conflicts against main's styling, view, and Vitest refactors: - Take main's DateRangePicker, Combobox, and react exports; drop the branch's DatePicker, CalendarContent, and open-range picker API, whose only consumers were the removed variable selectors. - Port registered-query coverage into tests/public-api and route the hosted starter through registeredQueryRoute in the test host. - Keep main's starter, re-applying only the registered query call. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

…variables # Conflicts: # dev/fixtures/bundle-host.tsx # examples/starter-data-app/index.tsx

francoischalifour · 2026-10-08T12:55:35Z

+Follow the [hosted build skill](https://github.com/altertable-ai/skills/blob/main/skills/build-data-app/SKILL.md)
+for the create/update tool workflow.


This repo should be unaware of the skills.

francoischalifour · 2026-10-08T12:55:49Z

+- [queries.json](../examples/starter-data-app/queries.json): maps query IDs to SQL
+  statements with [DuckDB parameters](contract.md#execute-named-queries) such as
+  `$groupName`. Keep this map out of the browser bundle.


Isn't this a local data app concept?

francoischalifour · 2026-10-08T12:56:53Z

+2. Move SQL from local server operations into `queries.json`, replace interpolated
+   inputs with `$name` parameters, and replace statement calls with
+   `query(id, values)`.


Ideally we provide a function for this, so that it's fast, determinist, and doesn't spend tokens.

feat: add registered queries and typed variable controls

fccfac5

robinvrd mentioned this pull request Oct 2, 2026

feat: register hosted data app queries and variables on create and update altertable-ai/skills#87

Closed

feat: align local app authoring with registered queries

b3cb09c

albert20260301 suggested changes Oct 3, 2026

View reviewed changes

feat!: separate registration and unify local iframe queries

e7d7522

robinvrd changed the title ~~feat: add registered queries and typed variable controls~~ feat!: unify registered queries for hosted and local iframe apps Oct 5, 2026

robinvrd mentioned this pull request Oct 5, 2026

feat: prepare CLI apps for registered iframe queries altertable-ai/altertable-cli#129

Closed

albert20260301 approved these changes Oct 5, 2026

View reviewed changes

Keep registered query rollout scoped to hosted data apps

ede893d

robinvrd changed the title ~~feat!: unify registered queries for hosted and local iframe apps~~ feat: register queries and typed variables for hosted data apps Oct 6, 2026

robinvrd added 2 commits October 6, 2026 16:19

docs: focus query guidance and remove repeated workflows

a1de1cf

chore: merge main and resolve hosted preview conflicts

8b1257e

robinvrd marked this pull request as ready for review October 6, 2026 14:38

robinvrd requested review from francoischalifour, leonkenneth and redox October 6, 2026 14:38

robinvrd added 5 commits October 6, 2026 17:09

refactor: leave registered query parsing and execution to backend

2ec617e

refactor: rename registered query adapter to queryById

9007d33

refactor: remove leftovers from earlier query execution scope

3428dc4

feat: share compact calendar pickers across date controls

2b3d6b3

style: tighten date input widths

75d065e

francoischalifour reviewed Oct 6, 2026

View reviewed changes

style: narrow and center date picker inputs

0e472a2

leonkenneth closed this Oct 7, 2026

leonkenneth reopened this Oct 7, 2026

leonkenneth and others added 4 commits October 8, 2026 11:43

Remove legacy API

e05043f

Merge remote-tracking branch 'origin/main' into robin/data-app-query-…

4538156

…variables # Conflicts: # dev/fixtures/bundle-host.tsx # examples/starter-data-app/index.tsx

francoischalifour reviewed Oct 8, 2026

View reviewed changes

leonkenneth closed this Oct 8, 2026

		from: range.start ? new Date(`${range.start}T00:00:00.000Z`) : null,
		to: range.end ? new Date(`${range.end}T23:59:59.999Z`) : null,

		Follow the [hosted build skill](https://github.com/altertable-ai/skills/blob/main/skills/build-data-app/SKILL.md)
		for the create/update tool workflow.

Conversation

robinvrd commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Hosted flow

Validation

Uh oh!

albert20260301 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

albert20260301 commented Oct 7, 2026

Uh oh!

leonkenneth commented Oct 7, 2026

Uh oh!

leonkenneth commented Oct 7, 2026

Uh oh!

leonkenneth commented Oct 7, 2026

Uh oh!

albert20260301 commented Oct 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

robinvrd commented Oct 2, 2026 •

edited

Loading