Repository navigation
fix(query): restore typed column descriptors - #56
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
redox
reviewed
Oct 12, 2026
| raise column_parse_error("expected a { \"name\", \"type\" } column object, got #{column.inspect}") | ||
| end | ||
|
|
||
| ColumnDescriptor["name" => name, "type" => type] |
Member
There was a problem hiding this comment.
I wouldn't even inherit from Hash it it's to only use it like this
Contributor
Author
There was a problem hiding this comment.
Yes I was afraid of silent re-serialization breaking, but it's probably overkill to be backward compatible for this
redox
approved these changes
Oct 12, 2026
utay
approved these changes
Oct 12, 2026
CI only tests Ruby 3.2+, and 3.0/3.1 are end-of-life. Raise the gemspec and RuboCop floor to match, and apply the anonymous argument forwarding RuboCop now asks for. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Drop the Hash subclass and its string-key access; Data provides value equality, hash, to_h and immutability. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.8.0 reduced
QueryResult#columns/query_all[:columns]to bare names, dropping column types. This restores typed column descriptors.ColumnDescriptors, aDataclass with#nameand#typereaders. They are immutable and compare by value.column["name"]no longer works.ParseError. Onlynameandtypeare kept.Datawas added in 3.2. The gemspec and RuboCop now target 3.2, which matches the CI matrix (3.0 and 3.1 are end-of-life). This also applies RuboCop's anonymous argument forwarding fixes (&,**) in the adapters and client..returnsin thequery_allRBI sig.specssubmodule.🤖 Generated with Claude Code