WIP Sanitise personalisation feature for Java client library#266
Draft
CrystalPea wants to merge 4 commits into
Draft
WIP Sanitise personalisation feature for Java client library#266CrystalPea wants to merge 4 commits into
CrystalPea wants to merge 4 commits into
Conversation
CrystalPea
force-pushed
the
mat-sanitise-personalisation
branch
2 times, most recently
from
a1ccfc3 to
97a2fca
Compare
rparke
reviewed
Jul 10, 2026
| } | ||
|
|
||
| @Override | ||
| @Override |
There was a problem hiding this comment.
I don't know if java cares about indentation for annotations but I think it should be one tab to the left
CrystalPea
force-pushed
the
mat-sanitise-personalisation
branch
from
97a2fca to
1d8aad2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that users can tell us to sanitise content for specific placeholders. This is part of the work to mitigate against the placeholder injection vulnerability.
Accompanying docs: alphagov/notifications-tech-docs#346
What problem does the pull request solve?
Checklist
CHANGELOG.mdsrc/main/resources/application.propertiespom.xml