Migrate tables to summary lists on platform-admin pages#5988
Open
kr8n3r wants to merge 2 commits into
Open
Conversation
Convert tables in the platform admin view to use the summary list component. - app/templates/views/platform-admin/get-dvla-billing-report.html - app/templates/views/platform-admin/get-billing-report.html - app/templates/views/platform-admin/daily-sms-provider-volumes-report.html - app/templates/views/platform-admin/users-list.html - app/templates/views/platform-admin/daily-volumes-report.html - app/templates/views/platform-admin/volumes-by-service-report.html
Functionality gone in #5228 so page can be removed.
kr8n3r
force-pushed
the
migrate-tebles-to-summary-list-platform-admin
branch
from
a3d640f to
3deb14e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Convert tables in the platform admin view to use the summary list component
Summary list is a more appropriate way to represent key:value pairs
Additionally:
"bottom-gutter-3-2wrapper with responsive margin on the summary list (govuk-!-margin-bottom-7)govuk-!-font-size-16) for the summary list - matches previous implementationRemove platform-admin/services page
Functionality gone in #5228 so page can be removed.
Visuals
Before
After