Adding reason to provider changes#5970
Open
whpearson wants to merge 2 commits into
Open
Conversation
whpearson
force-pushed
the
add_reason_to_providers
branch
from
40dabc0 to
78d9966
Compare
Contributor
Author
|
Needs alphagov/notifications-api#4887 merging first |
klssmith
reviewed
Jun 22, 2026
| ( | ||
| "reason", | ||
| GovukTextInputField( | ||
| "Reason", validators=[NotifyDataRequired(thing="your reason for changing the priorities")] |
Contributor
There was a problem hiding this comment.
Wondering if it would be helpful not to make this a required field - ideally people should put a reason down, but we've had an incident in the past where we manually changed the percentages at very frequent intervals. If that ever happened again, needing to enter the same reason each time might be time consuming
This adds a single field to the provider ratio form for a reason for the change. This is propagated to the call to the notifications-api. Tests have been updated
whpearson
force-pushed
the
add_reason_to_providers
branch
from
78d9966 to
be79cf9
Compare
quis
reviewed
Jul 1, 2026
Co-authored-by: Chris Hill-Scott <me@quis.cc>
whpearson
force-pushed
the
add_reason_to_providers
branch
from
9f7c947 to
12aab6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Form:
View:
This adds a single field to the provider ratio form for a reason for the change.
This is propagated to the call to the notifications-api.
Tests have been updated