Fix Awaitility step hierarchy with reusable executor threads#1350
Open
baev wants to merge 1 commit into
Open
Conversation
baev
added
the
pr:improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Keeps Allure report steps correctly scoped when Awaitility evaluates conditions on reusable executor threads. Steps recorded after
await()now remain at the expected test level instead of becoming nested under a completed Awaitility condition or disappearing, resolving #891.The integration also preserves nested await reporting, supports Awaitility 4.3’s supplier-consumer
untilAssertedworkflow, and cleans up an aborted condition before the same listener starts another wait. This works with the Awaitility version supplied by the user’s project and introduces no AspectJ runtime requirement.fixes #891
Checklist