Fix LinguaTagger ImportError referring to langdetect instead of lingua#288
Open
Chessing234 wants to merge 1 commit intoallenai:mainfrom
Open
Fix LinguaTagger ImportError referring to langdetect instead of lingua#288Chessing234 wants to merge 1 commit intoallenai:mainfrom
Chessing234 wants to merge 1 commit intoallenai:mainfrom
Conversation
LinguaTagger checks LINGUA_AVAILABLE but its ImportError message said 'langdetect is not installed' (copy-paste from LangdetectTagger). The install hint 'pip install dolma[lang]' is correct because the lang extras include lingua-language-detector, but the package name in the message misleads users. Update the package name to 'lingua' so the error accurately describes the missing dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
LinguaTagger.__init__checksLINGUA_AVAILABLEbut raisesImportError("langdetect is not installed, ..."), pointing users to the wrong package.https://github.com/allenai/dolma/blob/96f8b07/python/dolma/taggers/language.py#L254-L257
Root cause
Copy-paste from
LangdetectTagger.__init__at line 204-206, which correctly reportslangdetectwhenLANGDETECT_AVAILABLEis false. The message inLinguaTaggerwas never updated for the new availability flag.Fix
Change the message to
"lingua is not installed, ..."so it names the actually-missing package. Thepip install dolma[lang]hint is unchanged because thelangextras includelingua-language-detector.