Fix off-by-one in CodeCopyrightTagger._score span length#283
Open
Chessing234 wants to merge 1 commit intoallenai:mainfrom
Open
Fix off-by-one in CodeCopyrightTagger._score span length#283Chessing234 wants to merge 1 commit intoallenai:mainfrom
Chessing234 wants to merge 1 commit intoallenai:mainfrom
Conversation
Span uses exclusive-end convention (Span.__len__ returns end - start). The + 1 inflates the copyright coverage score by one character per span, making it systematically too high. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeCopyrightTagger._scorecomputes copyright coverage as:The
+ 1is incorrect.Spanuses Python's exclusive-end convention —Span.__len__returnsself.end - self.start, and all other span-length calculations in the codebase useend - startwithout+ 1. The extra+ 1inflates the score by one character per span, making copyright coverage systematically too high.Fix: Remove the
+ 1to match theSpanconvention.Test plan
Span.__len__returnsend - start(exclusive end, no+ 1)🤖 Generated with Claude Code