[WIP] feat: add nvme_support to image import features block#9654
Open
imlk0 wants to merge 1 commit into
Open
Conversation
- Move nvme_support parameter from disk_device_mapping to features block - Align with Alibaba Cloud SDK ImportImageFeatures struct - Add proper validation for supported/unsupported values - Update documentation and examples - Add comprehensive test cases for features functionality - Maintain backward compatibility with existing disk mappings
|
|
imlk0
force-pushed
the
feat/image-nvme-support
branch
from
3aacad6 to
8b38b22
Compare
imlk0
changed the title
imlk0
force-pushed
the
feat/image-nvme-support
branch
from
8b38b22 to
51aa563
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvme_supportparameter fromdisk_device_mappingblock to the newfeaturesblock inalicloud_image_importresource, aligned with theImportImageFeaturesstruct in alibaba-cloud-sdk-gonvme_supportvalues (supported/unsupported)featuresblockalibaba-cloud-sdk-goto v1.63.28 (required forImportImageFeaturesAPI support)Changes
alicloud/resource_alicloud_image_import.go— addfeaturesblock withnvme_supportfieldalicloud/resource_alicloud_image_import_test.go— add acceptance testswebsite/docs/r/image_import.html.markdown— update documentationgo.mod/go.sum— bump alibaba-cloud-sdk-go to v1.63.28