Skip to content

feat: 新增 ECS ENI 安全组挂载资源#9618

Open
mir-xiong wants to merge 1 commit into
aliyun:masterfrom
mir-xiong:master
Open

feat: 新增 ECS ENI 安全组挂载资源#9618
mir-xiong wants to merge 1 commit into
aliyun:masterfrom
mir-xiong:master

Conversation

@mir-xiong
Copy link
Copy Markdown

  • 新增 alicloud_ecs_eni_sg_attachment 资源,实现 ENI 安全组按集合合并挂载
  • 支持创建记录原始安全组、删除回滚原始关系,并增加状态等待与重试
  • 注册 provider 资源并补充文档与单元测试
  • 更新忽略规则,避免本地构建产物与 mise 配置误提交

- 新增 alicloud_ecs_eni_sg_attachment 资源,实现 ENI 安全组按集合合并挂载
- 支持创建记录原始安全组、删除回滚原始关系,并增加状态等待与重试
- 注册 provider 资源并补充文档与单元测试
- 更新忽略规则,避免本地构建产物与 mise 配置误提交
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


mirxiong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -0,0 +1,57 @@
package alicloud
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试需要覆盖真实的资源创建的场景,会创建真实的资源并验证结果。 可以参考其他资源的AccTest


* `network_interface_id` - (Required, ForceNew) The ID of the network interface.
* `attach_security_group_ids` - (Required, ForceNew, List) Security group IDs to merge into the network interface's existing security group relationship.
**NOTE:** The final relationship is guaranteed, but returned order from ECS may differ.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 告警框没有高亮显示。 需要前后都隔一样才能正确渲染。可以通过 https://registry.terraform.io/tools/doc-preview 预览下。
  2. 如果 attach_security_group_ids 存在服务端返回和本地配置顺序不一致的情况,在schema定义中需要压制下diff ,不然用户创建之后会出现diff, 需压多次改动配置

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants