alicloud_kvstore_instance/alicloud_redis_tair_instance: Added the field cert_download_url, ssl_expired_time, cert_common_name#9594
Open
Melonbun233 wants to merge 5 commits into
Conversation
|
|
Melonbun233
changed the title
Melonbun233
force-pushed
the
feat/kvstore-tair-ssl-metadata
branch
from
7be6758 to
fa0ae5f
Compare
…rom DescribeInstanceSSL Add cert_download_url, ssl_expired_time, cert_common_name as computed fields. Data is already returned by the API but was previously discarded. Closes aliyun#9587 (partial)
…a from DescribeInstanceSSL Add cert_download_url, ssl_expired_time, cert_common_name as computed fields. Data is already returned by the API but was previously discarded. Closes aliyun#9587 (partial)
Melonbun233
force-pushed
the
feat/kvstore-tair-ssl-metadata
branch
from
fa0ae5f to
2c3539e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cert_download_url,ssl_expired_time,cert_common_nameas computed attributes onalicloud_kvstore_instanceandalicloud_redis_tair_instanceDescribeInstanceSSLAPI but was previously discarded in the Read functionsCloses #9587
Changes
alicloud/resource_alicloud_kvstore_instance.god.Set()calls in Readalicloud/resource_alicloud_kvstore_instance_test.goalicloud/resource_alicloud_redis_tair_instance.god.Set()calls in Read (with nil-check pattern)alicloud/resource_alicloud_redis_tair_instance_test.gowebsite/docs/r/kvstore_instance.html.markdownwebsite/docs/r/redis_tair_instance.html.markdownNew Attributes
cert_download_urlstring(computed)ssl_expired_timestring(computed)cert_common_namestring(computed)Test plan
TestAccAliCloudKVStoreRedisInstance_6_0— verifies new fields are set when SSL enabled and cleared when disabledTestAccAliCloudKVStoreRedisInstance_5_0_memory_classic_cluster— same coverage for a different instance typeTestAccAliCloudRedisTairInstance_basic6473_raw— verifies new fields are set when SSL enabled