feat: add Claude/Cursor skills, and devcontainer enhancements#2554
Open
yyuuttaaoo wants to merge 2 commits intomainfrom
Open
feat: add Claude/Cursor skills, and devcontainer enhancements#2554yyuuttaaoo wants to merge 2 commits intomainfrom
yyuuttaaoo wants to merge 2 commits intomainfrom
Conversation
…ancements - Add .claude skills and project knowledge (code-review, compile, e2e, etc.) - Add/update .cursor skills and rules - Enhance devcontainer with Docker-in-Docker support - Update .gitignore for .claude and build artifacts - Update docker/Dockerfile_development_part Change-Id: Icb20af26e16c4611254644178361248a72894c5f Co-developed-by: Cursor <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 主要为 LoongCollector 仓库补充面向 Claude/Cursor 的“技能/知识库”文档与脚本，并增强 devcontainer 的 Docker-in-Docker（DinD）支持，便于本地开发、编译与 E2E 调试；同时调整开发镜像与 .gitignore 以适配新增资产与构建产物。
Changes:
- 新增并同步
.claude/与.cursor/的 skills/rules（编译、E2E、review、安全检查等项目知识）。 - devcontainer 增强：引入 DinD 安装脚本、启动脚本与持久化
/var/lib/docker卷挂载。 - 调整
docker/Dockerfile_development_part与.gitignore以适配新路径与忽略规则。
Reviewed changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| docker/Dockerfile_development_part | 调整容器内安装路径到 /usr/local/loongcollector，并改用控制脚本启动 |
| .gitignore | 扩大忽略规则（含 pb 产物与 IDE/AI 工具目录） |
| .devcontainer/start-dind.sh | 新增 DinD 启动与 cgroup v1 修复脚本 |
| .devcontainer/dind-install.sh | 引入 DinD 安装脚本（第三方脚本） |
| .devcontainer/devcontainer.json | devcontainer 运行参数调整，增加 DinD 数据卷与 postStart 启动 |
| .devcontainer/Dockerfile | devcontainer 镜像构建增强（安装 DinD、清理 repo 配置） |
| .cursor/skills/e2e/scripts/e2e-cleanup.sh | 新增 E2E 清理脚本 |
| .cursor/skills/e2e/reference.md | 新增 E2E 步骤参考文档 |
| .cursor/skills/e2e/SKILL.md | 新增 E2E 完整指南（设计/运行/调试） |
| .cursor/skills/compile/SKILL.md | 扩充编译指南（子模块、UT、Docker 等） |
| .cursor/rules/project-knowledge/config-pitfalls.mdc | 新增配置陷阱规则（ExcutionTimeout/onetime） |
| .claude/skills/testing-standards/SKILL.md | 新增测试标准文档 |
| .claude/skills/selfmonitor/SKILL.md | 新增自监控规范文档 |
| .claude/skills/security-check/scripts/security_reset.sh | 新增敏感信息历史清理脚本 |
| .claude/skills/security-check/scripts/security_check.sh | 新增敏感信息扫描脚本 |
| .claude/skills/security-check/SKILL.md | 新增安全检查 skill 文档 |
| .claude/skills/riper5-protocol/SKILL.md | 新增 RIPER-5 流程协议文档 |
| .claude/skills/review-standards/SKILL.md | 新增 Code Review 行为标准文档 |
| .claude/skills/project-knowledge/SKILL.md | 新增项目架构与规范知识库 |
| .claude/skills/omc-reference/SKILL.md | 新增 OMC 参考文档 |
| .claude/skills/mermaid/SKILL.md | 新增 Mermaid 约定文档 |
| .claude/skills/e2e/scripts/e2e-cleanup.sh | 新增（同步）E2E 清理脚本 |
| .claude/skills/e2e/reference.md | 新增（同步）E2E 步骤参考文档 |
| .claude/skills/e2e/SKILL.md | 新增（同步）E2E 完整指南 |
| .claude/skills/design-document/SKILL.md | 新增设计文档约定 |
| .claude/skills/compile/SKILL.md | 新增（同步）编译指南 |
| .claude/skills/commit/SKILL.md | 新增提交信息规范文档 |
| .claude/skills/code-review/scripts/update_comment_status.py | 新增 code-review 自动化脚本：更新评论状态 |
| .claude/skills/code-review/scripts/init_review_workspace.py | 新增 code-review 自动化脚本：初始化评审工作区 |
| .claude/skills/code-review/scripts/incremental_review_mapper.py | 新增 code-review 自动化脚本：增量映射 |
| .claude/skills/code-review/scripts/generate_comment_status_report.py | 新增 code-review 自动化脚本：生成状态报告 |
| .claude/skills/code-review/scripts/fetch_review_comments.py | 新增 code-review 自动化脚本：抓取 PR review threads/comments |
| .claude/skills/code-review/scripts/build_snapshot.py | 新增 code-review 自动化脚本：构建快照基线 |
| .claude/skills/code-review/references/reviewed_commits.template.json | 新增 code-review 模板：reviewed commits |
| .claude/skills/code-review/references/review-plan.template.md | 新增 code-review 模板：review plan |
| .claude/skills/code-review/references/meta.template.json | 新增 code-review 模板：meta |
| .claude/skills/code-review/references/failure-playbook.md | 新增 code-review 故障处理 playbook |
| .claude/skills/code-review/references/comment-status.template.json | 新增 code-review 模板：comment status |
| .claude/skills/code-review/SKILL.md | 新增 code-review 主 skill（流程化评审规范） |
| .claude/settings.json | 新增 Claude settings（启用插件配置） |
| .claude/rules/project-knowledge/config-pitfalls.mdc | 新增（同步）配置陷阱规则 |
| .claude/CLAUDE.md | 新增 Claude Code 的 OMC 引导文档 |
- Remove duplicate --privileged in devcontainer.json (keep top-level only)
- Use ${containerWorkspaceFolder} for postStartCommand path
- Remove chmod 666 /var/run/docker.sock (user already in docker group)
- Fix sensitive pattern regex to match real token lengths
- Fix REPO_ROOT in e2e-cleanup.sh using git rev-parse --show-toplevel
- Fix usage comment path in .claude e2e-cleanup.sh
Change-Id: Ibd72ada497e6fabdff5050756d75803eba64a011
Co-developed-by: Cursor <[email protected]>
messixukejia
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Icb20af26e16c4611254644178361248a72894c5f
Co-developed-by: Cursor [email protected]