Skip to content

add nano seconds support in LogFileReader and protocol converter#2522

Open
alexandnpu wants to merge 2 commits into
alibaba:mainfrom
alexandnpu:feature/add_nanosec_support
Open

add nano seconds support in LogFileReader and protocol converter#2522
alexandnpu wants to merge 2 commits into
alibaba:mainfrom
alexandnpu:feature/add_nanosec_support

Conversation

@alexandnpu
Copy link
Copy Markdown

  1. set nano second support in LogFileReader, which makes input_file plugin can set nanosecond in the log event
  2. set nano second in protocol converter when we want to flattern log events

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 28, 2026

CLA assistant check
All committers have signed the CLA.

@alexandnpu alexandnpu force-pushed the feature/add_nanosec_support branch from d83bfa3 to f9b3bfa Compare January 28, 2026 01:17
@Takuka0311
Copy link
Copy Markdown
Collaborator

Takuka0311 commented Apr 27, 2026

百炼自动化审查:建议保持开启。

本 PR 为 LogFileReader 与协议转换器新增纳秒级时间戳支持,通过全局配置项控制。变更聚焦、具备明确功能增强价值且当前可合并,无重复或已在 main 实现的迹象,应保持开启等待维护者审查。.

最佳落地路径:

建议维护者审查 C++ 侧 GetCurrentTimeInNanoSeconds 的跨平台实现与 Go 侧序列化逻辑,确认全局配置项接入符合项目规范。若 CI 通过且无回归,可合并入核心;必要时可要求作者补充对应单元测试与配置文档说明。.

已核对内容:

  • pr_status: PR 状态为 open,mergeable 为 true,已签署 CLA,未合并,无冲突,等待维护者审查。.
  • code_changes: 变更涉及 LogFileReader.cpp 与 Go 协议转换器,新增纳秒时间戳获取与序列化逻辑,受全局配置开关控制,代码增量清晰且向后兼容。. (core/file_server/reader/LogFileReader.cpp)
  • no_duplicate_or_superseded: 上下文与本地检索未发现已合并的同类实现或替代 PR,本 PR 仍为当前纳秒支持需求的唯一实现候选。.

百炼审查备注:模型 qwen3.6-max-preview;对照提交 7099f790b8a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants