feat: Integrate coolbpf cpu profiling feature in loongcollector by wokron · Pull Request #2391 · alibaba/loongcollector

wokron · 2025-09-18T14:18:17Z

No description provided.

CLAassistant · 2025-09-18T14:18:24Z

All committers have signed the CLA.

Copilot

Pull Request Overview

This PR integrates coolbpf CPU profiling capabilities into loongcollector by adding a new input_cpu_profiling plugin. The implementation enables continuous CPU profiling of specified processes through command-line pattern matching and container discovery.

Key changes:

New CPU profiling plugin with process discovery mechanism
Integration with coolbpf profiler library
Plugin registration and lifecycle management

Reviewed Changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
core/plugin/input/InputCpuProfiling.{h,cpp}	New plugin implementation for CPU profiling input
core/ebpf/plugin/cpu_profiling/*	Core CPU profiling manager and process discovery logic
core/ebpf/driver/CpuProfiler.h	Wrapper for coolbpf profiler library integration
core/ebpf/Config.{h,cpp}	CPU profiling configuration option handling
core/ebpf/include/export.h	Type definitions for CPU profiling
core/unittest/input/InputCpuProfilingUnittest.cpp	Unit tests for the input plugin
core/unittest/ebpf/*Unittest.cpp	Unit tests for CPU profiling components
Various CMakeLists.txt	Build system updates for new components

Comments suppressed due to low confidence (1)

core/unittest/input/InputCpuProfilingUnittest.cpp:1

Corrected spelling of 'CommandLines' to 'CommandLines' in comment context.

Copilot · 2025-11-06T02:19:24Z

+    static void handler_without_ctx(uint32_t pid, const char* comm, const char* stack, uint32_t cnt) {
+        mHandler(pid, comm, stack, cnt, mCtx);
+    }


Static members mHandler and mCtx accessed without synchronization in handler_without_ctx, which is called from Poll() while holding a lock, but could race with Start() and Stop() that modify these members. The callback could be invoked with stale or null pointer values.

Copilot · 2025-11-06T02:19:24Z

+    mEBPFAdapter->UpdatePlugin(PluginType::CPU_PROFILING,
+                               buildCpuProfilingConfig(std::move(totalPids), std::nullopt, nullptr, nullptr));


Passing null handler and context to buildCpuProfilingConfig during update will overwrite the valid handler set during initialization, breaking profiling event handling.

Copilot · 2025-11-06T02:19:25Z

+        int maxRetry = 5;
+        for (int retry = 0; retry < maxRetry; ++retry) {
+            if (QueueStatus::OK == ProcessQueueManager::GetInstance()->PushQueue(info.mQueueKey, std::move(item))) {
+                break;
+            }
+            std::this_thread::sleep_for(std::chrono::milliseconds(100));
+            if (retry == maxRetry - 1) {


[nitpick] Magic numbers 5 and 100 for retry attempts and sleep duration should be extracted as named constants or made configurable to improve maintainability and allow tuning.

Suggested change

int maxRetry = 5;

for (int retry = 0; retry < maxRetry; ++retry) {

if (QueueStatus::OK == ProcessQueueManager::GetInstance()->PushQueue(info.mQueueKey, std::move(item))) {

break;

}

std::this_thread::sleep_for(std::chrono::milliseconds(100));

if (retry == maxRetry - 1) {

for (int retry = 0; retry < kMaxQueuePushRetry; ++retry) {

if (QueueStatus::OK == ProcessQueueManager::GetInstance()->PushQueue(info.mQueueKey, std::move(item))) {

break;

}

std::this_thread::sleep_for(std::chrono::milliseconds(kQueuePushRetrySleepMs));

if (retry == kMaxQueuePushRetry - 1) {

Copilot · 2025-11-06T02:19:25Z

+        std::lock_guard guard(mMutex);
+        mRouter.clear();
+        for (auto& [configKey, pids] : result) {
+            for (auto& pid : pids) {
+                totalPids.insert(pid);
+                auto it = mRouter.emplace(pid, std::unordered_set<ConfigKey>{}).first;
+                auto& configSet = it->second;
+                configSet.insert(configKey);
+            }
+        }


Clearing mRouter in HandleProcessDiscoveryEvent creates a race condition with HandleCpuProfilingEvent which reads from mRouter. Events arriving between clear and rebuild could be lost or routed incorrectly.

Copilot · 2025-11-06T02:19:25Z

+    // TODO: make this non-static
+    inline static livetrace_profiler_read_cb_ctx_t mHandler = nullptr;
+    inline static void* mCtx = nullptr;


Static member variables for instance-specific handler and context violate encapsulation and prevent multiple CpuProfiler instances from working correctly. This TODO should be addressed before production use.

yyuuttaaoo · 2026-02-25T07:34:27Z

使用文档仿照其他插件补充一下

yyuuttaaoo · 2026-02-26T06:55:11Z

+        std::lock_guard<std::mutex> lock(mMutex);
+        if (mProfiler == nullptr) {
+            livetrace_enable_tracing();
+            mProfiler = livetrace_profiler_create();


有没有控制队列大小等资源相关的参数，如何约束其资源使用量呢

队列大小的控制是 coolbpf 侧提供的。其中根据 profile 周期确定了有界队列的大小。https://gitee.com/anolis/coolbpf/blob/master/src/profiler/src/probes/probes.rs#L274

wokron · 2026-03-06T00:29:54Z

使用文档仿照其他插件补充一下

文档已经补充了

Takuka0311 · 2026-04-27T08:23:59Z

百炼自动化审查：建议保持开启。

本 PR 为 LoongCollector 新增基于 coolbpf 的 CPU 性能剖析插件（input_cpu_profiling），包含核心 C++ 实现、eBPF 驱动适配、单元测试与中文文档。维护者已进行多轮代码审查，作者持续响应并修复问题。目前本 PR 因落后于 main 分支存在合并冲突，但功能实现完整且具有明确产品价值，属于活跃开发中的有效特性 PR。.

最佳落地路径：

建议作者 rebase 到最新 main 分支解决合并冲突，并继续跟进维护者审查意见。待 CI 通过且审查批准后由维护者合并至 main 分支。.

已核对内容：

PR State: 本 PR 处于 open 状态，mergeable 为 false，修改 51 个文件，新增 2568 行代码，引入了完整的 input_cpu_profiling 插件及相关测试与文档。. (core/plugin/input/InputCpuProfiling.cpp:1, 54222e9aae2b)
Review Activity: 维护者 yyuuttaaoo 于 2026 年 2-3 月进行了多轮详细审查，作者 wokron 积极回应并提交了数十次修复提交，包括补充文档、重构容器发现逻辑与修复竞态条件建议。. 公开文档：docs/cn/plugins/input/native/input-cpu-profiling.md。 (docs/cn/plugins/input/native/input-cpu-profiling.md:1, 54222e9aae2b)

百炼审查备注：模型 qwen3.6-max-preview；对照提交 7099f790b8a3。

yyuuttaaoo marked this pull request as ready for review November 6, 2025 02:17

Copilot AI review requested due to automatic review settings November 6, 2025 02:17

Copilot AI reviewed Nov 6, 2025

View reviewed changes

wokron force-pushed the support-coolbpf-cpu-profiling branch from ecf5b83 to a3a8e56 Compare November 7, 2025 01:48

wokron force-pushed the support-coolbpf-cpu-profiling branch from c00d080 to 0f58800 Compare November 27, 2025 09:24

wokron force-pushed the support-coolbpf-cpu-profiling branch 5 times, most recently from 2a5948d to 6c51221 Compare December 22, 2025 02:21

yyuuttaaoo self-requested a review February 24, 2026 06:53

yyuuttaaoo requested changes Feb 25, 2026

View reviewed changes

yyuuttaaoo reviewed Feb 25, 2026

View reviewed changes

Comment thread core/ebpf/plugin/cpu_profiling/CpuProfilingManager.cpp Outdated

yyuuttaaoo reviewed Feb 26, 2026

View reviewed changes

Comment thread core/ebpf/driver/CpuProfiler.h Outdated

yyuuttaaoo reviewed Feb 26, 2026

View reviewed changes

wokron added 13 commits March 3, 2026 17:43

link coolbpf libprofiler library

213516c

add CpuProfiler

2bc3e9e

eBPFDriver support cpu profiling

4a90e69

add ProcessScanner

c38f003

PluginOptions alias

e3f36d5

add CpuProfilingManager

fffe21d

add InputCpuProfiling

45bb109

handle invalid regex error

fddf0f9

send profiling event to queue

d03172b

misc updates

5c51899

add ProcessDiscoveryManager

815ceff

cpu profiling support multi config

bcd66af

remove old ProcessScanner

c83ba79

wokron added 7 commits March 3, 2026 17:44

UpdateDiscovery just pass ContainerDiff

42e627a

remove old UpdateDiscovery

bb6b550

move ContainerManager callback place

2abe71a

refactor ContainerManager callback logic

df3e33a

check regex in config init

90e2cd0

fix build

7ffdbb7

update option init test

1ffef40

wokron force-pushed the support-coolbpf-cpu-profiling branch from 8f81b95 to 1ffef40 Compare March 3, 2026 10:03

add missing format

8191f24

wokron force-pushed the support-coolbpf-cpu-profiling branch from 37e01d9 to 8191f24 Compare March 4, 2026 03:00

wokron added 18 commits March 4, 2026 11:02

update todo comment

f867fad

update ProcessDiscoveryManager sleep interval

ad368a1

valNs use uint64

888bdf6

remove mContainerHandlersMutex

b34daed

clean up apply diff logic

48da876

refactor profiling collect interval

c172191

parseStackCnt and addContentToEvent become static method

4b2d826

unittest use shorter discovery interval

7f5301c

check stack empty

ed1fb8a

reserve size in addContentToEvent

ced4e64

extract FindAllMatch method

631e70e

add process match cache

8408ccc

add test for addContentToEvent

d4d420e

update parseStackCnt

b540ae3

parseStackCnt unittest

cf4e7c3

add missing format

fa80ee9

add docs

bb22007

reserve space for jsonLabels

54222e9

		mEBPFAdapter->UpdatePlugin(PluginType::CPU_PROFILING,
		buildCpuProfilingConfig(std::move(totalPids), std::nullopt, nullptr, nullptr));

Conversation

wokron commented Sep 18, 2025

Uh oh!

CLAassistant commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yyuuttaaoo commented Feb 25, 2026

Uh oh!

Uh oh!

Uh oh!

yyuuttaaoo Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

wokron Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

wokron commented Mar 6, 2026

Uh oh!

Takuka0311 commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Sep 18, 2025 •

edited

Loading

Takuka0311 commented Apr 27, 2026 •

edited

Loading