feat: rerun metric & aggregator if panic#2382
Open
shunjiazhu wants to merge 1 commit into
Open
Conversation
Collaborator
|
百炼自动化审查:建议保持开启。 本 PR 为 timerRunner 引入了 panic 自动重启机制(rerunIfPanic),并针对 metric input 与 aggregator 启用了该特性。属于有效的核心运行器稳定性改进,包含单元测试。当前 PR 状态为不可合并(mergeable: false),需 rebase 至最新 main 分支。因涉及核心调度变更与递归重启逻辑,需维护者审查并发安全与栈深度风险后合并。. 最佳落地路径: 建议作者先将分支 rebase 至最新 main 以解决冲突。维护者审查时需重点评估 panicCallback 中递归调用 cc.Run 是否会导致 goroutine 累积或栈溢出,必要时可建议引入最大重启次数限制或退避策略。CI 验证通过且审查批准后合并。. 已核对内容:
百炼审查备注:模型 qwen3.6-max-preview;对照提交 30ac854deafd。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.