Skip to content

feat: rerun metric & aggregator if panic#2382

Open
shunjiazhu wants to merge 1 commit into
alibaba:mainfrom
shunjiazhu:feat/rerun-when-panic
Open

feat: rerun metric & aggregator if panic#2382
shunjiazhu wants to merge 1 commit into
alibaba:mainfrom
shunjiazhu:feat/rerun-when-panic

Conversation

@shunjiazhu
Copy link
Copy Markdown
Contributor

No description provided.

@Takuka0311
Copy link
Copy Markdown
Collaborator

Takuka0311 commented Apr 27, 2026

百炼自动化审查:建议保持开启。

本 PR 为 timerRunner 引入了 panic 自动重启机制(rerunIfPanic),并针对 metric input 与 aggregator 启用了该特性。属于有效的核心运行器稳定性改进,包含单元测试。当前 PR 状态为不可合并(mergeable: false),需 rebase 至最新 main 分支。因涉及核心调度变更与递归重启逻辑,需维护者审查并发安全与栈深度风险后合并。.

最佳落地路径:

建议作者先将分支 rebase 至最新 main 以解决冲突。维护者审查时需重点评估 panicCallback 中递归调用 cc.Run 是否会导致 goroutine 累积或栈溢出,必要时可建议引入最大重启次数限制或退避策略。CI 验证通过且审查批准后合并。.

已核对内容:

百炼审查备注:模型 qwen3.6-max-preview;对照提交 30ac854deafd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants