Fix buffer overflow vulnerability in deflatePrime function (CVE-2018-25032)#396
Open
yannaingtun wants to merge 1 commit intoalibaba:masterfrom
Open
Fix buffer overflow vulnerability in deflatePrime function (CVE-2018-25032)#396yannaingtun wants to merge 1 commit intoalibaba:masterfrom
yannaingtun wants to merge 1 commit intoalibaba:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a buffer overflow vulnerability in the deflatePrime function within zlib code. The vulnerability could allow attackers to cause crashes or potentially execute arbitrary code when using Z_FIXED compression mode.
The fix changes the buffer check from using s->d_buf to s->sym_buf, which ensures the pending buffer cannot overwrite the symbol table during operation.
Reference
CVE-2018-25032
Original fix in zlib: madler/zlib@5c44459