feat(dart): add TransformationOptions for ingestion transporter configuration#6321
Open
MarioAlexandruDan wants to merge 22 commits into
Open
feat(dart): add TransformationOptions for ingestion transporter configuration#6321MarioAlexandruDan wants to merge 22 commits into
MarioAlexandruDan wants to merge 22 commits into
Conversation
- Add TransformationOptions to client_core - Add transformationOptions field to ClientOptions - Generate algolia_client_ingestion Dart package - Add ingestion transporter wiring to SearchClient template - Implement chunkedPush, saveObjectsWithTransformation, partialUpdateObjectsWithTransformation, and replaceAllObjectsWithTransformation extensions - Update pubspec_overrides across docs/tests/playground
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Up to standards ✅🟢 Issues
|
MarioAlexandruDan
force-pushed
the
feat/dart-transformation-options
branch
from
b15c29b to
44910b3
Compare
MarioAlexandruDan
force-pushed
the
feat/dart-transformation-options
branch
from
a7ec108 to
ee6ec15
Compare
MarioAlexandruDan
force-pushed
the
feat/dart-transformation-options
branch
from
d1bdb33 to
026e618
Compare
…deduplicate additionalProperties, Platform alias
… handling, and requestOptions timeouts in tests
…ix Mustache traversal
…Exception is RuntimeException
…thout endpoint-level timeouts
Fluf22
reviewed
May 13, 2026
Collaborator
Fluf22
left a comment
Fluf22
left a comment
There was a problem hiding this comment.
I don't understand the changes you made around server timeouts, I might be missing something
Comment on lines
+213
to
+227
| for (var retries = 0; retries < 50; retries++) { | ||
| try { | ||
| await transporter.getEvent( | ||
| runID: runID, | ||
| eventID: eventID, | ||
| requestOptions: requestOptions, | ||
| ); | ||
| return; | ||
| } on AlgoliaApiException catch (e) { | ||
| if (e.statusCode != 404) rethrow; | ||
| } | ||
| await Future<void>.delayed( | ||
| Duration(milliseconds: (retries * 1500).clamp(0, 5000)), | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
Silently returns after 50 retries
Add a throw exception at the end
| required String eventID, | ||
| RequestOptions? requestOptions, | ||
| }) async { | ||
| for (var retries = 0; retries < 50; retries++) { |
Collaborator
There was a problem hiding this comment.
The default is 100 now, and we want to pass maxRetries from the calling method I believe (check Dart jira ticket for maxRetries update)
Comment on lines
+116
to
+118
| connectTimeout: ingestionOpts?.connectTimeout ?? const Duration(seconds: 25), | ||
| readTimeout: ingestionOpts?.readTimeout ?? const Duration(seconds: 25), | ||
| writeTimeout: ingestionOpts?.writeTimeout ?? const Duration(seconds: 25), |
Collaborator
There was a problem hiding this comment.
Shouldn't we let the ingestion code default the right duration?
Because if we change in the future, we would have two places to change instead of one
Comment on lines
+224
to
+227
| ) + {{/vendorExtensions.x-timeouts}}{{^vendorExtensions.x-timeouts}}RequestOptions( | ||
| writeTimeout: Duration(milliseconds: {{{serverWriteTimeout}}}), | ||
| readTimeout: Duration(milliseconds: {{{serverReadTimeout}}}), | ||
| connectTimeout: Duration(milliseconds: {{{serverConnectTimeout}}}), |
Collaborator
There was a problem hiding this comment.
Not sure to understand why you added that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Part of the effort to standardize transformationOptions across all 11 language SDKs. Depends on the JS + Foundation ticket for CTS infrastructure.
🎟 JIRA Ticket API-379:
Changes included:
🧪 Test