-
Notifications
You must be signed in to change notification settings - Fork 37
feat(specs): add draft schema for Agentic Analytics #6167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sirockin
wants to merge
17
commits into
main
Choose a base branch
from
vnts-121-draft-schema-for-agentic-analytics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
909c958
feat(specs): add draft schema for Agentic Analytics
sirockin 6a9ae71
chore: run bundler
sirockin 84b340f
chore: add githook packages to package.json
sirockin b88c2e7
chore: rename InstantSearchTelemetry event and add examples
sirockin 6db0d0c
chore: add instantSearch property to other event schemas
sirockin 4953000
chore: rename instantSearch -> agent
sirockin 00a5fbb
chore: edit InstantSearch in line with feedback
sirockin f283426
chore: rename instant-search->instantsearch
sirockin c0972a1
chore: update bundled insights spec
sirockin 44764e2
chore: remove index from example
sirockin 2a5e728
chore: revert changes to bundled spec
sirockin 388757c
Merge branch 'main' into vnts-121-draft-schema-for-agentic-analytics
sirockin 261ec6f
Merge branch 'main' into vnts-121-draft-schema-for-agentic-analytics
sirockin e138ef2
Merge branch 'vnts-121-draft-schema-for-agentic-analytics' of github.…
sirockin 19e54df
chore: revert bundled spec to main
sirockin 1446abd
chore: revert bundled spec to main
sirockin d6b7956
chore: remove from all agent fields except
sirockin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,8 +17,10 @@ | |
| "clean": "rm -rf **/dist **/build **/.build **/node_modules **/.gradle **/vendor **/bin **/obj **/__pycache__ || true", | ||
| "cli": "yarn workspace scripts start", | ||
| "docker:setup": "./scripts/docker/setup.sh", | ||
| "eslint": "eslint", | ||
| "fix:json": "eslint '**/*.json' --fix", | ||
| "github-actions:lint": "eslint '.github/**/*.yml'", | ||
| "lint-staged": "lint-staged", | ||
| "postinstall": "husky && yarn workspace eslint-plugin-automation-custom build", | ||
| "playground:browser": "yarn workspace javascript-browser-playground start", | ||
| "scripts:build": "yarn workspace scripts build:actions", | ||
|
|
@@ -48,5 +50,6 @@ | |
| "engines": { | ||
| "node": "^24.0.0", | ||
| "yarn": "^4.0.0" | ||
| } | ||
| }, | ||
| "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" | ||
| } | ||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| type: object | ||
| title: Instant Search Telemetry Event | ||
| description: | | ||
| Tracks an initial user interaction with the Agentic Analytics API. | ||
| properties: | ||
| eventType: | ||
| $ref: './InstantSearchTelemetryEvent.yml' | ||
| eventName: | ||
| $ref: './EventAttributes.yml#/eventName' | ||
| sessionID: | ||
| $ref: './EventAttributes.yml#/sessionID' | ||
| userToken: | ||
| $ref: './EventAttributes.yml#/userToken' | ||
| # This is not specified in the Agentic Analytics document but is optional in all other schemas | ||
| # Can we keep it here for consistency? | ||
| authenticatedUserToken: | ||
| $ref: './EventAttributes.yml#/authenticatedUserToken' | ||
| timestamp: | ||
| $ref: './EventAttributes.yml#/timestamp' | ||
| performance: | ||
| description: free form object for performance data. | ||
| type: object | ||
| widgets: | ||
| description: free form object for widget information. | ||
| type: object | ||
| required: | ||
| - eventName | ||
| - sessionID | ||
| - eventType | ||
| - userToken | ||
| x-discriminator-fields: | ||
| - eventType |
2 changes: 2 additions & 0 deletions
2
specs/insights/common/schemas/InstantSearchTelemetryEvent.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| type: string | ||
| enum: [instantsearch_telemetry] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this cannot work for us infortunately because events with only
messageIDshould remain valid.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. How about we make messageID required?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please could you give us some more context about the use of messageID and conversationID?
Also a bit more context about when
toolCallIDandagentIDwould and wouldn't be used.For example, I'd understood that a message was always part of a conversation.