fix(clients): deserialization and HTTP header handling#6100
Merged
Conversation
Fluf22
requested review from
MarioAlexandruDan and
morganleroi
and removed request for
a team
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Fluf22
changed the title
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 48 |
TIP This summary will be updated as you push new changes.
… null values in parameter generation
Replace direct JSONAssert/Quibble calls with custom lenient JSON assertion helpers that keep only the expected structure from the actual response (union-based comparison). Also marks test helper files as hand-written in generation.config.mjs.
Python: handle non-string input for list types, add dict type deserialization in api_response.py Scala: add withHeader(key, Option[Any]) overload that skips None values in HttpRequest.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #5860 — generic client fixes for Python and Scala.
Changes