-
Notifications
You must be signed in to change notification settings - Fork 0
Improve mobile dispatch and transcript logs #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { hasPromptMarker } from './startup-ready.js'; | ||
|
|
||
| describe('hasPromptMarker', () => { | ||
| it('ignores help text that appears before the actual prompt', () => { | ||
| const content = [ | ||
| 'Welcome to Gemini CLI', | ||
| 'type your message or @path/to/file', | ||
| '? for shortcuts', | ||
| '', | ||
| ].join('\n'); | ||
|
|
||
| expect(hasPromptMarker(content)).toBe(false); | ||
| }); | ||
|
|
||
| it('detects a ready prompt on the last line', () => { | ||
| expect(hasPromptMarker('> ')).toBe(true); | ||
| expect(hasPromptMarker('❯ ')).toBe(true); | ||
| expect(hasPromptMarker('> Refactor the login flow')).toBe(true); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| export function hasPromptMarker(content: string): boolean { | ||
| const lines = content | ||
| .split('\n') | ||
| .map((line) => line.replace(/\u001b\[[0-9;]*[A-Za-z]/g, '').trimEnd()) | ||
| .filter(Boolean); | ||
|
|
||
| const lastLine = lines.at(-1)?.trim() ?? ''; | ||
| if (!lastLine) { | ||
| return false; | ||
| } | ||
|
|
||
| if (/^[>❯$#]\s*$/.test(lastLine)) { | ||
| return true; | ||
| } | ||
|
|
||
| if (/^[>❯$#]\s+\S+/.test(lastLine)) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { formatReadableTranscript } from './readable-transcript.js'; | ||
|
|
||
| describe('formatReadableTranscript', () => { | ||
| it('preserves markdown structure and strips terminal chrome', () => { | ||
| const raw = [ | ||
| 'cc-12345/projects/demo', | ||
| 'IMPLEMENTATION PLAN', | ||
| '- Update the login flow', | ||
| '- Add tests', | ||
| '', | ||
| 'const answer = 42', | ||
| 'console.log(answer)', | ||
| '', | ||
| 'DONE', | ||
| ].join('\n'); | ||
|
|
||
| const formatted = formatReadableTranscript(raw); | ||
|
|
||
| expect(formatted).toContain('## IMPLEMENTATION PLAN'); | ||
| expect(formatted).toContain('- Update the login flow'); | ||
| expect(formatted).toContain('- Add tests'); | ||
| expect(formatted).toContain('```text'); | ||
| expect(formatted).toContain('const answer = 42'); | ||
| expect(formatted).toContain('console.log(answer)'); | ||
| expect(formatted).toContain('## DONE'); | ||
| expect(formatted).not.toContain('cc-12345'); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silently swallowing errors from
appendTranscriptcan make debugging difficult if transcript recording fails. While transcript recording is best-effort, logging the error would provide visibility into potential issues (e.g., disk space, permissions) without crashing the main process.