Repository navigation
fix: fix and re-enable integration tests - #418
Merged
Merged
Conversation
satterly
force-pushed
the
fix/integration-tests
branch
from
March 29, 2026 16:07
075c284 to
ac9f545
Compare
- Remove deprecated jinja2.ext.autoescape extension from mailer.py (autoescape=True is already set as a keyword argument) - Fix KeyError in validate_rules when a rule field is missing 'regex' by adding a break guard after the inner validation loop - Fix test_rules_dont_exist and test_rules_parsing: use assert_called_once_with instead of called_once_with, mock os.path.dirname properly, and fix expected return value - Re-enable integration test CI step in both postgres and mongodb jobs Fixes #391 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
satterly
force-pushed
the
fix/integration-tests
branch
from
March 29, 2026 16:09
ac9f545 to
d145bb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jinja2.ext.autoescapeextension fromintegrations/mailer/mailer.py(same fix as [Issue-Fix] jinja2.ext.autoescape extension #408 but for the integration, not the plugin)KeyErrorcrash invalidate_rules()when a rule field is missing theregexkeycalled_once_with->assert_called_once_with, mockos.path.dirnameproperly, correct expected return valueFixes #391
Test plan
🤖 Generated with Claude Code