fix(docs): correct errors in gas manager admin openapi spec#1401
Merged
Conversation
Fix mismatches between the public Gas Manager Admin spec and the actual meta-manage REST surface: camelCase request/response fields, corrected stats numeric types, accurate enums, pagination limits, and removal of non-existent success-envelope error/delete bodies. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🔗 Preview Mode
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5075a7058f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jakehobbs
changed the title
Top-level networks is not required for any policy type: erc20 derives networks from erc20Rules.tokens (the field is ignored), and the other types fall back to the app default. Clarify in the description which types use it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pavelm
approved these changes
Jun 23, 2026
SahilAujla
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns the public Gas Manager Admin OpenAPI spec (
src/openapi/admin/admin.yaml) with the actual REST API shape served bymeta-manage, fixing field-name, type, enum, and response-envelope mismatches without adding any undocumented endpoints.Related Issues
N/A
Changes Made
solanaRules,erc20Rules,gasPumpId, and nested ERC-20 fieldstokenAddress,recipientAddress,usePostOp,priceMultiplier, etc.).stats/details→stats/detailed, changed USD stats fields fromstringtonumber, native-token fields tointeger, and addederc20Stats.bundler_sponsorshiptoPolicyType, introduced aPolicyStatusenum (active,inactive,pending_approval,rejected), and constrained sponsorshipstatustoPENDING/MINED/EXPIRED./policiesmax50; sponsorships default15, max100withbefore/after), added thenameFilterquery param, and removed the non-existent success-envelopeerrorobjects and the fake delete-response body.Testing
pnpm run validate)