Skip to content

fix: evita NPE in ItemBuilder.build() con placeholder dal valore null #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
antoilmalvagio wants to merge 1 commit into from
Closed

fix: evita NPE in ItemBuilder.build() con placeholder dal valore null #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions bukkit/src/main/java/it/mycraft/powerlib/bukkit/item/ItemBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,10 +460,13 @@ public ItemStack build() {
this.lore = new ArrayList<>();
}

for (String placeholder : placeholders.keySet()) {
Object value = placeholders.getOrDefault(placeholder, "NULL");
setName(this.name.replace(placeholder, value.toString()));
setLore(this.lore.stream().map((s) -> s.replace(placeholder, value.toString()))
for (Map.Entry<String, Object> entry : placeholders.entrySet()) {
// getOrDefault protegge solo dalla chiave assente: se il valore mappato e' null
// va comunque gestito qui, altrimenti value.toString() lancia NPE.
Object raw = entry.getValue();
String value = raw != null ? raw.toString() : "NULL";
setName(this.name.replace(entry.getKey(), value));
setLore(this.lore.stream().map((s) -> s.replace(entry.getKey(), value))
.collect(Collectors.toList()));
}
String name = this.name;
Expand Down