Fix crash on use-after-free on macOS#46
Merged
chrisduerr merged 1 commit intoalacritty:masterfrom Jun 18, 2022
Merged
Conversation
The code is inspired by glfw NSPasteboard clipboard loading. Fixes alacritty#6141.
kchibisov
force-pushed
the
fix-macos-crash
branch
from
cbc60ae to
94a6952
Compare
Member
Author
|
@Lurk does this fixes your issue as well? Since without it alacritty segfaults right away after your patch in #33. For more see alacritty/alacritty#6141. |
Member
madsmtm
approved these changes
Jun 17, 2022
Contributor
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
Can attest that you now follow Cocoa's memory management rules properly (haven't tested it though)
Contributor
|
@kchibisov I just checked, and there is no leak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code is inspired by glfw NSPasteboard clipboard loading.
Fixes alacritty/alacritty#6141.