TASK 13-14: pyflink users need geography schemas#15
Open
gkalashyan-akv wants to merge 25 commits into
Open
Conversation
gkalashyan-akv
force-pushed
the
task/pyflink-users-need-geography-schemas
branch
from
June 24, 2026 14:43
e7bf0ce to
d07218d
Compare
gkalashyan-akv
force-pushed
the
task/pyflink-users-need-geography-schemas
branch
from
July 7, 2026 13:51
d07218d to
6edc215
Compare
gkalashyan-akv
force-pushed
the
task/pyflink-users-need-geography-schemas
branch
from
July 7, 2026 16:48
6edc215 to
78991ba
Compare
gkalashyan-akv
force-pushed
the
task/pyflink-users-need-geography-schemas
branch
from
July 7, 2026 16:57
c4e0d17 to
86810f9
Compare
talatuyarer
reviewed
Jul 14, 2026
talatuyarer
left a comment
Collaborator
There was a problem hiding this comment.
I believe this PR is not working. It needs more careful work. There are four paths and also we can use the "everywhere BITMAP appears" as rule to add new type.
- from_elements (data in): Python pickles rows, then Java PythonTableUtils.converter() switches on the column's LogicalType to build a converter per field.
- collect() (data out): Java PythonBridgeUtils.getPickledBytesFromJavaObject() switches on the type to pickle each field. No Geography branch → the raw GeographyData object falls to the generic pickler, which can't handle it.
- UDFs: types cross to the Python worker via a proto enum (flink-fn-execution.proto TypeName) plus coders.py. zero GEOGRAPHY entries.
- pandas/Arrow: to_arrow_type in types.py and Java ArrowUtils — zero GEOGRAPHY entries.
| @@ -228,6 +228,15 @@ def __init__(self, length=1, nullable=True): | |||
| def __repr__(self): | |||
Collaborator
There was a problem hiding this comment.
I believe this is not enough. adding a type to Flink means updating many parallel stacks what we did in Java. PyFlink has the same structure: types.py is only the declaration layer (Python class, Java↔Python DataType mapping). The data layers are separate: pickling between the Python driver and JVM, the UDF worker protocol, and Arrow for pandas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation
Was generative AI tooling used to co-author this PR?