Skip to content

TASK 9: row and codegen integration#11

Open
gkalashyan-akv wants to merge 6 commits into
devfrom
task/row-and-codegen-integration
Open

TASK 9: row and codegen integration#11
gkalashyan-akv wants to merge 6 commits into
devfrom
task/row-and-codegen-integration

Conversation

@gkalashyan-akv

Copy link
Copy Markdown
Collaborator

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@gkalashyan-akv
gkalashyan-akv force-pushed the task/row-and-codegen-integration branch 3 times, most recently from 6cf5451 to 72581b5 Compare June 16, 2026 13:07
s"$term.toObject($serTerm).hashCode()"
case BITMAP =>
s"$term.hashCode()"
case GEOGRAPHY =>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we clarify and test the equality/hash contract for GEOGRAPHY here? BinaryGeographyData currently inherits byte-based BinarySection.hashCode()/equals(), so this works for the current implementation. But GeographyData is a public interface and does not state that all implementations must use WKB-byte equality/hash semantics. Since GROUP BY/JOIN equality for GEOGRAPHY is supposed to be based on stored/canonical WKB bytes, it would be useful to either document that invariant on GeographyData or add a generated hash/equaliser test with two distinct GeographyData.fromBytes(...) instances carrying the same WKB.

@gkalashyan-akv
gkalashyan-akv force-pushed the task/row-and-codegen-integration branch from cc3c6ac to 6d9a6b1 Compare June 24, 2026 14:42
@gkalashyan-akv
gkalashyan-akv force-pushed the task/row-and-codegen-integration branch 2 times, most recently from 753eb8e to 8a4db35 Compare July 7, 2026 16:10
@gkalashyan-akv
gkalashyan-akv force-pushed the task/row-and-codegen-integration branch from 8a4db35 to f9c934d Compare July 14, 2026 14:25
@gkalashyan-akv
gkalashyan-akv force-pushed the task/row-and-codegen-integration branch from f9c934d to 20c50b0 Compare July 14, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants