TASK 9: row and codegen integration#11
Open
gkalashyan-akv wants to merge 6 commits into
Open
Conversation
gkalashyan-akv
force-pushed
the
task/row-and-codegen-integration
branch
3 times, most recently
from
June 16, 2026 13:07
6cf5451 to
72581b5
Compare
davidchaava
reviewed
Jun 17, 2026
| s"$term.toObject($serTerm).hashCode()" | ||
| case BITMAP => | ||
| s"$term.hashCode()" | ||
| case GEOGRAPHY => |
Collaborator
There was a problem hiding this comment.
Could we clarify and test the equality/hash contract for GEOGRAPHY here? BinaryGeographyData currently inherits byte-based BinarySection.hashCode()/equals(), so this works for the current implementation. But GeographyData is a public interface and does not state that all implementations must use WKB-byte equality/hash semantics. Since GROUP BY/JOIN equality for GEOGRAPHY is supposed to be based on stored/canonical WKB bytes, it would be useful to either document that invariant on GeographyData or add a generated hash/equaliser test with two distinct GeographyData.fromBytes(...) instances carrying the same WKB.
gkalashyan-akv
force-pushed
the
task/row-and-codegen-integration
branch
from
June 24, 2026 14:42
cc3c6ac to
6d9a6b1
Compare
gkalashyan-akv
force-pushed
the
task/row-and-codegen-integration
branch
2 times, most recently
from
July 7, 2026 16:10
753eb8e to
8a4db35
Compare
Runtime representation and serializer Cover geography serializer with SerializerTestBase
gkalashyan-akv
force-pushed
the
task/row-and-codegen-integration
branch
from
July 14, 2026 14:25
8a4db35 to
f9c934d
Compare
gkalashyan-akv
force-pushed
the
task/row-and-codegen-integration
branch
from
July 14, 2026 14:49
f9c934d to
20c50b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation
Was generative AI tooling used to co-author this PR?