Repository navigation
fix(onboarding): offer choose my provider once bids are in, with a bid picked - #4630
Merged
Merged
Conversation
…d picked "Choose my provider" showed while the deployment was still being created and opened an empty bid list, and most people who pressed it left. It now shows once every placement has an open bid, and the manual pick opens with the bid the autopilot would have leased already selected, so Deploy is ready to press. Skip now says the deployment keeps going when it really does: its lease was sent or created, or the api took the whole one-click deploy on. While the page still drives the deployment, Skip keeps asking before it closes it. Fixes CON-1431
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
Warning Review limit reached
This review includes 15 billable files and costs up to $3.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 46 minutes for your next included review. View limit details
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4630 +/- ##
==========================================
+ Coverage 93.73% 93.91% +0.17%
==========================================
Files 1813 1704 -109
Lines 52620 49814 -2806
Branches 12946 12388 -558
==========================================
- Hits 49323 46782 -2541
+ Misses 2953 2704 -249
+ Partials 344 328 -16
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ℹ️ No blocking issues — one semantic nit inline.
Reviewed changes
A first full pass over the PR (1 commit, 15 files, deploy-web onboarding auto-deploy flow).
- Bid-gated "Choose my provider" — the CTA now renders only in the matching phase and only once every placement has an open bid to pick from, instead of unconditionally during matching or creating.
- Hand-off with a pick —
setBidStrategynow carriesrecommendedBidIds(per placement: the autopilot's matched provider, else the first open bid, skipping providers a failed lease went to), and the manual form records those selections once viaselectProvider, so pressing Deploy goes straight to the review step. - Skip messaging — the leave guard gains
keepsDeployingWithoutPage(lease sent/created, or the api took the one-click deploy on), and skipping then enqueues an info snackbar ("Your deployment keeps going") instead of leaving silently. - Analytics —
onboarding_choose_provider_clickgainsdseqandnumberOfBids;onboarding_leftgainsdeploymentKeepsGoing.
Verified locally: all 7 touched spec files pass (572 tests), tsc -p tsconfig.build.json and eslint on the touched files are clean, and the Snackbar usage matches the @akashnetwork/ui contract (info variant registered on the provider).
GLM-5.3 ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of CON-1431
In the Oct 26-27 failure-session report, 13 of 35 new Hello World and Space Agent users left the one-click flow within 30 s. Nine of them pressed "Choose my provider", mostly before any bid had come in, and landed on an empty bid list. One of the 13 got a lease, against 16 of the 22 who let the deploy run.
What
background_auto_lease).onboarding_choose_provider_clickgainsdseqandnumberOfBids, andonboarding_leftgainsdeploymentKeepsGoing.Gap: while the page itself drives the deployment (no API auto lease), skipping during create or matching still closes it, and the existing dialog says so. The API only takes over the lease of a deployment it created with
autoLease, so keeping it going there needs an endpoint that hands an open deployment to theAutoLeasejob. Turningbackground_auto_leaseon removes this path for new one-click deploys.Testing: unit tests for each change. The deploy-web unit suite, lint and tsc (no new errors) pass locally, and the mutation check on changed lines scores 100%.