Skip to content

feat(notifications): alert on verification changes - #3723

Draft
chalabi2 wants to merge 4 commits into
akash-network:mainfrom
chalabi2:aep-86/console-verification-notifications
Draft

feat(notifications): alert on verification changes#3723
chalabi2 wants to merge 4 commits into
akash-network:mainfrom
chalabi2:aep-86/console-verification-notifications

Conversation

@chalabi2

Copy link
Copy Markdown

Why

Part of CON-800.

Tenants need advance notice of provider maintenance and a clear warning when an
active lease no longer meets its AEP-86 verification tier. Leases remain open;
these alerts expose the changed provider facts without changing lease lifecycle.

What

  • consume provider maintenance events through the existing chain-event pipeline
  • poll the Console API verification feed for tier-demotion transitions
  • resolve active leases affected by each provider change
  • deduplicate and claim notification delivery through additive persistence
  • keep maintenance and tier-demotion delivery independently flag-gated
  • add unit and functional coverage for retries, deduplication, and alert delivery

Dependencies

The generated Drizzle migration is isolated in its own commit.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

Comment thread package-lock.json
@@ -42,7 +42,7 @@
"license": "Apache-2.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔄 Carefully review the package-lock.json diff

Resolve the comment if everything is ok

* node_modules/@akashnetwork/chain-sdk                                                     1.0.0-alpha.41 -> 1.0.0-alpha.43

@socket-security

socket-security Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​akashnetwork/​chain-sdk@​1.0.0-alpha.41 ⏵ 1.0.0-alpha.4385 +1100100 +198100

View full report

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.89340% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.84%. Comparing base (37e3cc2) to head (ea56537).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tion-alert/provider-tier-demotion-alert.service.ts 85.91% 8 Missing and 2 partials ⚠️
...tier-demotion/provider-tier-demotion.repository.ts 92.50% 2 Missing and 1 partial ⚠️
...ert/model-schemas/provider-tier-demotion.schema.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3723      +/-   ##
==========================================
+ Coverage   79.76%   79.84%   +0.07%     
==========================================
  Files        1186     1194       +8     
  Lines       31867    32060     +193     
  Branches     7848     7882      +34     
==========================================
+ Hits        25418    25597     +179     
- Misses       5688     5705      +17     
+ Partials      761      758       -3     
Flag Coverage Δ
api 90.34% <ø> (-0.03%) ⬇️
deploy-web 71.02% <ø> (ø)
log-collector 85.85% <ø> (ø)
notifications 94.25% <92.89%> (-0.07%) ⬇️
provider-console 81.38% <ø> (ø)
provider-inventory 84.98% <ø> (ø)
provider-proxy 88.22% <ø> (ø)
tx-signer 90.19% <ø> (ø)
Files with missing lines Coverage Δ
...ents/handlers/chain-events/chain-events.handler.ts 100.00% <100.00%> (ø)
...alert/dto/event-provider-maintenance-opened.dto.ts 100.00% <100.00%> (ø)
...ert/repositories/alert/alert-json-fields.schema.ts 100.00% <100.00%> (ø)
...dules/alert/repositories/alert/alert.repository.ts 94.73% <100.00%> (+0.79%) ⬆️
...er-active-leases/provider-active-leases.service.ts 100.00% <100.00%> (ø)
...enance-alert/provider-maintenance-alert.service.ts 100.00% <100.00%> (ø)
...motion-feed/provider-tier-demotion-feed.service.ts 100.00% <100.00%> (ø)
...modules/alert/types/provider-tier-demotion.type.ts 100.00% <100.00%> (ø)
...s/src/modules/chain/providers/registry.provider.ts 100.00% <100.00%> (ø)
...chain-events-poller/chain-events-poller.service.ts 96.73% <ø> (ø)
... and 5 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
@chalabi2
chalabi2 force-pushed the aep-86/console-verification-notifications branch from 92a6496 to 7304b9d Compare August 27, 2026 16:51
Keep the optional placement verification field optional at the JSON boundary and avoid expanding the generated type union while building the notifications registry.

Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
@chalabi2
chalabi2 force-pushed the aep-86/console-verification-notifications branch from 7304b9d to ea56537 Compare August 27, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant