Skip to content

test(console): cover deployment disappearing before delete - #108

Open
chalabi2 wants to merge 1 commit into
mainfrom
fix/console-close-delete-404-coverage
Open

chalabi2 wants to merge 1 commit into
mainfrom
fix/console-close-delete-404-coverage

Conversation

@chalabi2

@chalabi2 chalabi2 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

The v0.1.3 release gate found three uncovered lines when a deployment disappears after an active GET preflight and DELETE returns 404. Existing tests returned 404 during preflight and never reached that branch.

Add a regression test asserting ErrAlreadyClosed, exactly one GET and DELETE, and exactly one failed close action-log entry. Document this existing behavior in DESIGN.md and SPEC.md and add the required changelog fragment. Runtime code is unchanged.

Validation:

  • Console package tests and race check pass with release build tags.
  • The previously uncovered block now has an execution count of 1, up from 0.
  • The fresh coverage-reports artifact from CI run 36165345267 passes the full v0.1.2-to-HEAD changed-line gate: 100% of 603 executable lines, with no exceptions. This independently verifies the release coverage gap is closed.
  • CI build, unit tests, race detection, offline E2E, fresh-chain E2E, lint, changelog, and changed-line coverage checks pass.
  • Live Console lifecycle and live coverage report pass on retry of the same commit. The first attempt failed while reading provider logs after status and ingress passed; cleanup completed. The diagnostic suppressed the underlying error, so its exact cause is unconfirmed.
  • Local changelog and whitespace checks pass.

After core-team review and merge, a separate generated changelog PR must merge before the unpublished v0.1.3 tag moves to repaired main and release publication is retried.

Failed release: https://github.com/akash-network/akt/actions/runs/36160047975

Exercise an active close preflight followed by a DELETE 404. Assert the
already-closed error, one submission, and one failed action-log entry.
This closes the release-range coverage gap blocking v0.1.3.

Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
@chalabi2
chalabi2 requested a review from a team as a code owner September 25, 2026 17:09
@chalabi2
chalabi2 enabled auto-merge (squash) September 25, 2026 17:09
@chalabi2
chalabi2 deployed to console-sandbox September 25, 2026 17:38 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
console-sandbox — 61429646 Deployed Sep 25, 2026 by chalabi2 via e2e-console-sandbox #260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant