Conversation
Exercise an active close preflight followed by a DELETE 404. Assert the already-closed error, one submission, and one failed action-log entry. This closes the release-range coverage gap blocking v0.1.3. Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
chalabi2
enabled auto-merge (squash)
September 25, 2026 17:09
chalabi2
had a problem deploying
to
console-sandbox
September 25, 2026 17:14 — with
GitHub Actions
Failure
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.1.3 release gate found three uncovered lines when a deployment disappears after an active GET preflight and DELETE returns 404. Existing tests returned 404 during preflight and never reached that branch.
Add a regression test asserting
ErrAlreadyClosed, exactly one GET and DELETE, and exactly one failed close action-log entry. Document this existing behavior in DESIGN.md and SPEC.md and add the required changelog fragment. Runtime code is unchanged.Validation:
coverage-reportsartifact from CI run 36165345267 passes the full v0.1.2-to-HEAD changed-line gate: 100% of 603 executable lines, with no exceptions. This independently verifies the release coverage gap is closed.After core-team review and merge, a separate generated changelog PR must merge before the unpublished v0.1.3 tag moves to repaired main and release publication is retried.
Failed release: https://github.com/akash-network/akt/actions/runs/36160047975