Conversation
…ange - apply_85's app_name defaults to None, so annotate it Optional[str] - restore the original (min, max) = RANGES[application] line so the age PR diff stays focused on the age feature Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Closing — wrong base. Reopening this against dmonakhov:derive-age so it lands inside #72 instead of duplicating it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #72 (
dmonakhov:derive-age) — merge after it. Only the last commit is new; the rest is #72.Two review nits from #72:
apply_85'sapp_nameparameter defaults toNone, so annotate itOptional[str]instead ofstr.(min, max) = RANGES[application]line incheck_rangeso the age PR diff stays focused on the age feature.Tests: 357 passed. black and flake8 clean.
Made with Cursor