Skip to content

feat: support for arrays of mergeable objects in the “with” argument of “$merge”#15

Open
azaslavsky wants to merge 1 commit into
ajv-validator:masterfrom
azaslavsky:arrays-for-with
Open

feat: support for arrays of mergeable objects in the “with” argument of “$merge”#15
azaslavsky wants to merge 1 commit into
ajv-validator:masterfrom
azaslavsky:arrays-for-with

Conversation

@azaslavsky
Copy link
Copy Markdown

This is a working implementation of the feature proposed in #14. It would also close #12.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e84920a on azaslavsky:arrays-for-with into d847ec3 on epoberezkin:master.

@epoberezkin
Copy link
Copy Markdown
Member

@azaslavsky Thank you, I will review

@vganapat
Copy link
Copy Markdown

Hello, I was looking for the fix to #12 and was wondering, is there an update on the PR review?

@epoberezkin
Copy link
Copy Markdown
Member

The fix to #12 is very simple, there is a separate PR for that. To support an array instead of a simple schema, there is no need to change the package completely. Instead of passing "json-merge-patch" package as is, you just need to pass a wrapper around this package that understands arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

jsonpatch.apply is deprecated, please use applyPatch for applying patch sequences, or applyOperation to apply individual operations.

4 participants