Write daily IRs for incremental aggregation#998
Open
kambstreat wants to merge 66 commits intoairbnb:mainfrom
Open
Write daily IRs for incremental aggregation#998kambstreat wants to merge 66 commits intoairbnb:mainfrom
kambstreat wants to merge 66 commits intoairbnb:mainfrom
Conversation
pengyu-hou
reviewed
Jun 10, 2025
| s"${aggregationPart.inputColumn}_$opSuffix${aggregationPart.window.suffix}${bucketSuffix}" | ||
|
|
||
| def incOutputColumnName = | ||
| s"${aggregationPart.inputColumn}_$opSuffix${bucketSuffix}" |
Collaborator
There was a problem hiding this comment.
should we still keep the aggregationPart.window.suffix? Otherwise, how do we reconstruct the final output column?
Author
There was a problem hiding this comment.
@pengyu-hou not sure I get it. I can not use the window.suffix right as the intermediate incremental is daily aggregation.
pengyu-hou
reviewed
Jun 10, 2025
| .toArray | ||
| .zip(columnAggregators.map(_.irType)) | ||
|
|
||
| val incSchema = aggregationParts |
Collaborator
There was a problem hiding this comment.
I am thinking that we should use a full incremental in the code and we can keep inc as the suffix for the table so the table names are not getting too long. What do you think?
Suggested change
| val incSchema = aggregationParts | |
| val incrementalSchema = aggregationParts |
pengyu-hou
reviewed
Jun 20, 2025
pengyu-hou
reviewed
Jul 17, 2025
…hronon into kchakka/incremental
Co-authored-by: Pengyu Hou <3771747+pengyu-hou@users.noreply.github.com> Signed-off-by: chaitanya <1847554+kambstreat@users.noreply.github.com>
…hronon into kchakka/incremental
…hronon into kchakka/incremental
…hronon into kchakka/incremental
….scala
GroupBy.scala — bug fixes
- Fix aggregationParts returning empty when no holes exist: Previously derived from the hole-filling loop, so when the incremental table was already up-to-date, convertIncrementalDfToHops received an empty list
and produced wrong hops. Now derived directly from groupByConf unconditionally.
- Fix maxWindow.get NPE: Replaced with getOrElse(throw ...) that gives a clear error message when incremental mode is used on a GroupBy with no windowed aggregations.
- Remove unused imports: Operation and com.google.common.collect.Table.
- Fix typo: "aggregatiosn" → "aggregations" in scaladoc.
GroupByIncrementalTest.scala — test improvements
- Enable UNIQUE_COUNT and BOUNDED_UNIQUE_COUNT: Uncommented both operations in testIncrementalBasicAggregations. Comparison converts array IRs to their sizes (since element ordering/MD5 hashing differs between
Chronon and SQL) and validates against count(distinct ...) from SQL.
- Rewrite testIncrementalStatisticalAggregations: Replaced schema-only checks with a full incremental-vs-non-incremental snapshotEvents comparison for SKEW, KURTOSIS, APPROX_PERCENTILE, APPROX_UNIQUE_COUNT, and
APPROX_HISTOGRAM_K.
- Remove redundant column-existence assertions: Dropped assertTrue("IR must contain X") checks that were superseded by the value comparison.
- Remove unused BinaryType import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR address the following CHIP : #984
Why / Goal
The goal of the PR is to reduce the time taken to compute aggregations. Added daily level partial aggregates for batch feature computation, which avoids reading past day's event level data.
With this change, we see, 4x improvement for computing features. (except first time run )
Test Plan
Checklist
Reviewers