Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @overload | ||
| def __get__(self, inst: None, owner: Optional[type[object]] = None) -> Self: ... | ||
| def __get__(self, inst: None, owner: type[object] | None = None) -> Self: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
… into update-typehints
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 97.63% 97.64%
=======================================
Files 17 17
Lines 847 848 +1
Branches 44 44
=======================================
+ Hits 827 828 +1
Misses 12 12
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I ran pyupgrade on this file and made a few adjustments to allow 3.9 to sill be backwards compatible.
Are there changes in behavior for the user?
Not really but users should be aware that 3.9 could be dropped at any point in the future. For now, I have added
from __future__ import annotationsto provide any needed backwards compatibility for this version but users should start thinking about updating to newer versions of python in the meantime.Related issue number
Checklist