Upgrade flake8-import-order and flake8-requirements#572
Merged
webknjaz merged 1 commit intoMay 6, 2026
Merged
Conversation
112c628 to
64f94c2
Compare
- flake8-import-order: 0.18.2 -> 0.19.2 - flake8-requirements: 2.2.1 -> 2.3.0 These packages were using the deprecated pkg_resources module which has been removed from setuptools in version 82.0.0, causing flake8 to fail with 'ModuleNotFoundError: No module named pkg_resources'.
64f94c2 to
c94ba70
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 97.86% 97.78% -0.08%
==========================================
Files 23 23
Lines 5701 5701
Branches 766 766
==========================================
- Hits 5579 5575 -4
- Misses 77 80 +3
- Partials 45 46 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Codecov says there's some coverage drop, but it doesn't seem related. So I'll merge this bump regardless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These packages were using the deprecated pkg_resources module which has been removed from setuptools in version 82.0.0, causing flake8 to fail with 'ModuleNotFoundError: No module named pkg_resources'.
Are there changes in behavior for the user?
No
Related issue number
Fixes the continuous integration failure in #568.
Checklist
python -m flake8 aiosmtpd{py36,py37,py38,py39}-{nocov,cov,diffcov}{py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs{py36,pypy3}-{nocov,cov,diffcov}, qapy36-{nocov,cov,diffcov}, qa, docsNEWS.rstfile