tox static: fix platform regex for fullmatch#571
Merged
webknjaz merged 1 commit intoaio-libs:masterfrom May 6, 2026
Merged
Conversation
Contributor
Author
|
mypy did not detect any of these errors. Would you prefer to suppress them in pytype rather than make code changes? |
Member
|
Sounds like there's two separate changes mixed up in this PR. At least, put them into separate PRs? |
re.fullmatch('^(?!win32)(?!cygwin)') will only match start of line followed by
not 'win32' and not 'cygwin' followed by nothing meaning an empty string.
This causes static to be skipped on platforms it was intended to be run on
such as linux.
Fix by changing the regular expression to '^(?!win32)(?!cygwin).*$' which will
full match start of line followed by not 'win32' and not 'cygwin' followed by
anything followed by end of line.# Please enter the commit message for your changes. Lines starting
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 97.86% 97.84% -0.02%
==========================================
Files 23 23
Lines 5701 5701
Branches 766 766
==========================================
- Hits 5579 5578 -1
- Misses 77 79 +2
+ Partials 45 44 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
I have dropped the fixes for the issues detected by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Are there changes in behavior for the user?
No.
Related issue number
Related #544.
Checklist
static{py36,py37,py38,py39}-{nocov,cov,diffcov}{py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs{py36,pypy3}-{nocov,cov,diffcov}, qapy36-{nocov,cov,diffcov}, qa, docsNEWS.rstfile