Fix tox diffcover#569
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #569 +/- ##
==========================================
- Coverage 97.89% 97.84% -0.06%
==========================================
Files 23 23
Lines 5701 5701
Branches 766 766
==========================================
- Hits 5581 5578 -3
- Misses 75 79 +4
+ Partials 45 44 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cov-report uses current working directory as the default output
location. Set two cov-report output locations; the default location
used by Codecov and _dump/coverage-{env:INTERP}.xml used by diffcover.
diff-cover changed its default comparison branch from `origin/master` to `origin/main` in release 5.0.0.
|
There's 5 failed tests in the Windows job: https://github.com/aio-libs/aiosmtpd/actions/runs/25456153086/job/74686050166#step:5:589 This seems unrelated so I've restarted the CI. Though, it's probably worth investing and digging through the logs. If the tests are flaky, they should be stabilized. |
|
Note: I realized just now that the CI is not calling tox but invokes pytest and coverage directly, bypassing some shared configuration. I think it'd be good to start integrating |
I looked through the log. The failing tests are appear to Windows no allowing the same port to be reused in quick succession while this is not triggered on the Linux. I do not have a Windows system to debug the issue. I did notice some tests are already skipped on Windows. |
I was planning on getting all current tox environments passing first. I estimate about five more pull requests four singles and a multiple commit one covering flake8 and hopefully they should all be passing. |
What do these changes do?
Fix tox diffcover failure by:
Are there changes in behavior for the user?
No.
Related issue number
Related #544.
Checklist
{py36,py37,py38,py39}-diffcov{py36,py37,py38,py39}-{nocov,cov,diffcov}{py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs{py36,pypy3}-{nocov,cov,diffcov}, qapy36-{nocov,cov,diffcov}, qa, docsNEWS.rstfile