Replace ByteString with bytearray#556
Closed
manisandro wants to merge 1 commit intoaio-libs:masterfrom
Closed
Conversation
Member
There was a problem hiding this comment.
Why bytearray? There are defaults here which are clearly bytes, not bytearray, and the docs suggest replacing it with Buffer.
https://docs.python.org/3/library/typing.html#typing.ByteString
Contributor
There was a problem hiding this comment.
Agreed; I'll have to take a closer look, but Buffer is probably the more correct option
Contributor
|
Closes #549 |
|
Python 3.14 is released. We need an aiosmtpd release that supports Python 3.14. |
|
Dear maintainers, could you please proceed with the merge? |
webknjaz
approved these changes
May 7, 2026
Fixes build with python 3.14
Member
|
#575 covers the runtime changes. Feel free to port the docs changes for that in a separate PR. |
auto-merge was automatically disabled
May 7, 2026 16:31
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build with python 3.14