Skip to content

test: isolate Playwright fixture event loops #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aiden0z merged 1 commit into from
Sep 16, 2026
Merged

test: isolate Playwright fixture event loops #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/e2e/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,11 @@ def dev_server_url(request):
# Playwright Fixtures
# ---------------------------------------------------------------------------

@pytest.fixture(scope="session")
# sync_playwright owns an asyncio loop while its context is open. Module scope keeps browser reuse
# within E2E modules without leaking that loop into later tests that call asyncio.run().
@pytest.fixture(scope="module")
def browser():
"""Launch a Playwright Chromium browser for the test session."""
"""Launch Chromium for one browser-backed test module."""
with sync_playwright() as p:
channel = os.getenv("PPTX_E2E_BROWSER_CHANNEL", "").strip()
launch_options = {"headless": True}
Expand Down
Loading