Repository navigation
fix(x402): meter the sender's STX fee on auto-payments - #714
Merged
Merged
Conversation
createApiClient booked only the payment amount; the self-paid fee (up to 0.003 STX) was never metered, so x402 gas was uncapped unlike transferStx and callContract. The fee is now resolved before reserve() and booked in ustx with the amount. Closes #713
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createApiClientbooked only the payment amount. The self-paid transaction's fee (sbtc_transfer/token_transferclamp, up to 0.003 STX) was never metered, so x402 gas was uncapped, unliketransferStxandcallContract.reserve(), and book it inustxalongside the amount (one multi-unit reservation, booked whole or not at all).Closes #713